-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Fix for missing Fulltext Image in Newsfeeds #38058
Open
AndySDH
wants to merge
35
commits into
joomla:5.3-dev
Choose a base branch
from
AndySDH:patch-12
base: 5.3-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
75ee1a8
Update FeedView.php
AndySDH 8d11d54
Update FeedView.php
AndySDH 59cdbb4
make phpcs happy
AndySDH 59421be
make phpcs happy
AndySDH 3252be5
Merge branch '4.2-dev' into patch-12
AndySDH 215a036
Update FeedView.php
AndySDH dc0b151
Update FeedView.php
AndySDH 390d210
Update FeedView.php
AndySDH ca184a9
Update FeedView.php
AndySDH 4444745
Update components/com_content/src/View/Category/FeedView.php
AndySDH 1b14f85
Update components/com_content/src/View/Featured/FeedView.php
AndySDH 9ef3237
Make it more readable
AndySDH 0f93b63
Make it more readable
AndySDH a07bfbf
Update components/com_content/src/View/Featured/FeedView.php
AndySDH ab15286
Update components/com_content/src/View/Category/FeedView.php
AndySDH 3717861
Merge branch '4.2-dev' into patch-12
AndySDH 6c8d06a
Merge tag 'psr12anchor' into psr12/merge/38058
joomla-bot 866b35b
Phase 1 convert BRANCH to PSR-12
joomla-bot c9470a2
Phase 2 convert BRANCH to PSR-12
joomla-bot 988d765
Merge tag 'psr12final' into psr12/merge/38058
joomla-bot 3a3f20b
Update the PR with cleaner code
AndySDH b81bef7
Update FeedView.php
AndySDH 26fc96c
Update FeedView.php
AndySDH 39160d3
Update FeedView.php
AndySDH 1669e46
Merge branch '4.3-dev' into patch-12
AndySDH 655b354
Merge branch 'joomla:4.3-dev' into patch-12
AndySDH 73a7562
Merge branch '5.1-dev' into patch-12
AndySDH 1edec5d
Merge branch '5.2-dev' into patch-12
AndySDH f7d942c
Update components/com_content/src/View/Category/FeedView.php
AndySDH 03ec896
Ensure alt properties are set
AndySDH a78558a
Ensure alt properties are set
AndySDH 416f473
Merge branch '5.2-dev' into patch-12
richard67 f06aefa
Update components/com_content/src/View/Category/FeedView.php
Quy 5cf9bff
Update components/com_content/src/View/Featured/FeedView.php
Quy 507aca5
Merge branch '5.2-dev' into patch-12
Quy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
$obj
is null, then the following error:Checking for the alt property should not be necessary so remove the check/assignment.
PS: The code is self explanatory so these comments don't provide additional information.