Update npm dependencies #38041
Update npm dependencies #38041
Conversation
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
joomla-cms-bot
added
NPM Resource Changed
|
@roland-d there is already a pull request for skipto. Has been here for a long time waiting on merging. There are also pull; requests for codemirror and tinymce This PR is almost certainly wrong. But it cant be tested/verified because of 11,481 additions, 6,706 deletions What you are missing is that for some of these packages there is additional steps to be taken which are in the build scripts. At a minimum you should include a list of the packages that have been updated and the versions. One way to do this is to run |
|
@brianteeman Thank you for the feedback. This is my first time updating this thing, so feel free to tell me what is wrong. Yes I am aware that it is basically untestable but not updating isn't an option either. I am fine to close this if someone else wants to pick this up.
Is there any info on what is the right way?
I don't have to guess if there is any information on that.
Found them, going to have a look at it.
Updated the first post with that information. |
|
If you check the joomla build scripts you will find that for tinymce, codemirror, jooa11y, accessibility and skipto there are specific things that need to take place when they are updated. (there may be others but those are the ones I am personally aware of In other words npm update is only the first part of the process of updating those scripts. You can see this your self by either checking the build scripts or simply run Because of this there is specific things that need to be checked for these three such as that the version number in the plugins are bumped etc etc. For that reason I had created pull requests for each of those so that they could be tested and updated correctly. tinymce #37949 |
|
Why is this for 4.2? It should be for 4.1 |
|
That is because 4.1-dev is closed for merging and Benjamin does not expect another 4.1.x release to come out. I will check all the other PRs later as well. |
|
So you think its ok to be releasing joomla with outdated scripts - how sad. |
|
LOL, it is really not about what I think. I don't know how you reached the conclusion about what I think, I am just stating the situation and has nothing to do with what I think. I can tell you what I think and that is that we should always ship with the most up-to-date versions possible. If I really would think what you think I am thinking then I would not make the effort for updating the NPM and composer packages. |
that's all anyone can ask for |
|
Just that you understand a bit more the context why Roland is doing this updates. We have been discussing in the last maintainers meeting when would be the best time to update our dependencies regularly. We have been decided to do that before the first beta normally, but for 4.2 before the second beta. Here is the link to the report https://volunteers.joomla.org/teams/cms-maintenance-team/reports/1744-meeting-notes-june-08-2022. |
|
Thanks for the info @laoneo |
|
That practice is OK for scripts that are simple dependencies but doesnt work when the script itself is the extension. eg skipto, tinymce, codemirorr |
|
In theory, when the script follows semver, then it should be fine to update when we not do a major bump of it. |
|
and that's all I have asked for. Yet the pull requests I created for these exact scenarios were all ignored for 4.1 and now flagged as being for 4.2 |
|
Now that you have updated tinymce etc this will need redoing. From experience it is easier to recreate the pr than to try and resolve the conflicts |
|
Would you like me to do it for you? |
|
@brianteeman If you can please. |
|
no problem - close this here and I will create a new pr |
|
Thank you. |
Summary of Changes
This is the result of a
npm updateto update our dependencies to their current versions as supported by our PHP minimum standard.@brianteeman I cannot update the
skiptoplugin to anything higher than 4.1.3 because the newer versions are missing thecompiledfolder. Is that something you can look into?The output of
npm outdatedbeforeThe output of
npm outdatedafterTesting Instructions
npm ciin the root of your siteActual result BEFORE applying this Pull Request
The site works as expected.
Expected result AFTER applying this Pull Request
The site works as expected.
Documentation Changes Required
None