[4.2] Update deleted files and folders for 4.2-beta1 #37979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Update the lists of files and folders to be deleted on update by script.php to the latest changes in the 4.2-dev branch in preparation of the upcoming 4.2.0 Beta 1.
Some folders have already been added with PR #37912 , but it needs to delete also all stuff inside these folders, and the folders have to be in alphabetically descending order in the list so subfolders are deleted before their parent folders.
Changes from PR #36751 - see https://github.com/joomla/joomla-cms/pull/36751/files#diff-6e79b8dcfcf48c49f12b78d5d2c631b91c199dbfc39181c7f80e2d08ca703548 :
Changes from PR #37788 - see https://github.com/joomla/joomla-cms/pull/37788/files#diff-ae190cb5a3211dd66bd21b04b0cf008d7667f71095e580a92467352a5bfd6cb8 :
Changes from PR #37912 - see https://github.com/joomla/joomla-cms/pull/37912/files#diff-360f9716fcf3fdb5a8d9a109c8c16460cc8b47e25ad08ed4b4ba9d3916f7e9f8 :
Also from PR #37912 :
Testing Instructions
Code review.
Or if you want to make a real test, update a 4.2.0-alpha3 to the last 4.2 nightly build to get the actual result, and update a 4.2.0-alpha3 to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
Not all files and folders mentioned in the description above are deleted when updating from 4.2.0-alpha3.
Expected result AFTER applying this Pull Request
All files and folders mentioned in the description above all deleted when updating from 4.2.0-alpha3.
Documentation Changes Required
None.