[4.0] [a11y] Update _icomoon.scss px => rem #30436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
|
I have tested this item ✅ successfully on 29fdeaa See comment. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30436. |
Screenshot after testing. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30436. |
|
I have tested this item ✅ successfully on 29fdeaa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30436. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30436. |
Quy
removed
NPM Resource Changed
|
Merging thanks |
joomla-cms-bot
added
NPM Resource Changed
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Sep 29, 2020
…om_templates * '4.0-dev' of github.com:joomla/joomla-cms: (70 commits) [4.0] Child templates consistency (joomla#30387) [4.0] favicon changes to support child templates (joomla#30388) [4.0] Update Readme for Api tests (joomla#30539) [4.0] [Multilingual Status module] Adding displaying a possible error if URL Language Code is empty (joomla#30537) [4.0] Display of horizontal mod_articles_news module (joomla#30527) [4.0] Useless installation lang strings (joomla#30568) [4.0] Numbers not digits (joomla#30559) [4.0] Accessibility plugin position (joomla#30552) [4.0] fix for inherit fields (joomla#30557) [4.0] Redundant words (joomla#30555) add missing legend to fieldset (joomla#30528) [4.0] [a11y] add statement on found results (joomla#30535) [4.0] com_finder ul instead of dl for easier styling (joomla#30534) [4.0] Messages/Alerts: using icons instead of text as heading (joomla#30516) [4.0] Increase API Test Coverage (joomla#26722) [4.0] Implementing display of password requirements for frontend (joomla#30473) [4.0] FieldsHelper: Choose a first available category correctly (joomla#30268) Sort options (joomla#30531) Clear checkboxes on back button (joomla#30498) Update _icomoon.scss (joomla#30436) ...
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #29411 .
Summary of Changes
This small PR will replace the
pxset in _icomoon byrem.Using relative sizes instead of absolute sizes will make this part of the Joomla a wee more a11y.
This PR is just a small piece of all replaces that have to be done.
Testing Instructions
Cmd + Shift + C(Ctrl + Shift + Con Windows)) Your pointer is in Inspect Element mode, go ahead and click an element on the webpagenpm run build:cssActual result BEFORE applying this Pull Request
Before PR the values of the items
width,heightandline-heightare set to14pxExpected result AFTER applying this Pull Request
After applying PR the values of the items
width,heightandline-heightare set to1remDocumentation Changes Required