Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TinyMCE wrong JS field name #28321

Closed
wants to merge 1 commit into from
Closed

Fix TinyMCE wrong JS field name #28321

wants to merge 1 commit into from

Conversation

mvanvu
Copy link
Contributor

@mvanvu mvanvu commented Mar 12, 2020

Pull Request for Issue #27809.

Testing Instructions

Please see at #27809 (comment)

Expected result

This PR should be fixed for this issue #27809

@Fedik
Copy link
Member

Fedik commented Mar 12, 2020

Be careful with changing name stuff for tinymce plugin, it changes the behavior, and make b.c. break.
It also breaks the feature #11157 #10996 (especially if editor in a subform).

@mvanvu
Copy link
Contributor Author

mvanvu commented Mar 12, 2020

@Fedik I have tested with subform by the article subform field and it still works the same before. Just show here some conflicts you saw.

@Fedik
Copy link
Member

Fedik commented Mar 12, 2020

if you run test from #11157 it will not work anymore, it changes names

@mvanvu
Copy link
Contributor Author

mvanvu commented Mar 16, 2020

@Fedik Yes, the name has been changed or the issue #27809 will not resolve. I think the custom plugin that overrides the JS options should be updated the name. In other way, if the #11157 is already in the J! CORE, OK just close this and remember #27809 is an immortal issue :( .

@zero-24
Copy link
Contributor

zero-24 commented Jun 12, 2022

As the mentiond PR has been merged into 3.7 i will close here as requested.

@zero-24 zero-24 closed this Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants