Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Admin custom menu item #27469

Merged
merged 1 commit into from
Jan 11, 2020
Merged

Conversation

brianteeman
Copy link
Contributor

When you create a custom admin menu there is the possibility to add translations for each menu item using the language override system.

The actual text that will be displayed for the menu item is displayed in a read only field.

This PR gives it some styling love and care

Pull Request for Issue #27448 .

Before

image

After

image

When you create a custom admin menu there is the possibility to add translations for each menu item using the language override system.

The actual text that will be displayed for the menu item is displayed in a read only field.

This PR gives it some styling love and care
@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 1e5db67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27469.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jan 10, 2020

I have tested this item ✅ successfully on 1e5db67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27469.

@Quy Quy removed the PR-4.0-dev label Jan 10, 2020
@Quy
Copy link
Contributor

Quy commented Jan 10, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27469.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 10, 2020
@wilsonge wilsonge merged commit b194e10 into joomla:4.0-dev Jan 11, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Jan 11, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 11, 2020
@brianteeman
Copy link
Contributor Author

thx

@brianteeman brianteeman deleted the admin-menu branch January 11, 2020 00:20
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
When you create a custom admin menu there is the possibility to add translations for each menu item using the language override system.

The actual text that will be displayed for the menu item is displayed in a read only field.

This PR gives it some styling love and care
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants