Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Searchtools mobile display #27443

Merged
merged 6 commits into from
Jan 10, 2020
Merged

[4.0] Searchtools mobile display #27443

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ded3480
[4.0] Searchtools mobile display
infograf768 Jan 9, 2020
8b25305
simplifying
infograf768 Jan 9, 2020
1b1ba2a
simplifying +
infograf768 Jan 9, 2020
118dc6f
Merge branch '4.0-dev' into 4.0_searchtools_mobile
infograf768 Jan 10, 2020
dd5f0c0
Merge branch '4.0-dev' into 4.0_searchtools_mobile
infograf768 Jan 10, 2020
6b206ec
Merge branch '4.0-dev' into 4.0_searchtools_mobile
infograf768 Jan 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions administrator/templates/atum/scss/blocks/_toolbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,7 @@ joomla-toolbar-button {
width:100%;
}
}
.ordering-select,
.js-stools-container-selector {
.ordering-select {
margin-right:.5rem;
@include media-breakpoint-down(sm) {
[dir=rtl] & {
Expand Down
75 changes: 71 additions & 4 deletions administrator/templates/atum/scss/system/searchtools/searchtools.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,54 @@
margin-left: 0.5rem;
margin-right: 0;
}

@include media-breakpoint-down(sm) {
float: none !important;
width: 100%;

[dir=ltr] & {
margin-right: 0;
}

[dir=rtl] & {
margin-right: 0;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the value is the same for LTR and RTL you should not need to have individual settings

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. There are other places to also simplify. let's wait for more small changes to modify.


@include media-breakpoint-down(xs) {
float: none !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already defined under media-breakpoint-down(sm)

width: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already defined under media-breakpoint-down(sm)


[dir=ltr] & {
margin-right: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already defined under media-breakpoint-down(sm)

}

[dir=rtl] & {
margin-right: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already defined under media-breakpoint-down(sm)

margin-left: 0;
}
}

.js-stools-field-selector {
@include media-breakpoint-down(sm) {
max-width: 100%;
margin-right: 0;

[dir=rtl] & {
margin-right: 0;
}
}

@include media-breakpoint-down(xs) {
max-width: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already defined under media-breakpoint-down(sm)

margin-right: .5rem;

[dir=rtl] & {
margin-right: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already defined under media-breakpoint-down(sm)

margin-left: 0;
}
}
}
}

.js-stools-container-selector-first {
Expand All @@ -116,10 +164,6 @@
[dir=rtl] & {
margin-left: 0.5rem;
}
}

.js-stools-container-selector,
.js-stools-container-selector-first {

@include media-breakpoint-down(sm) {
float: none !important;
Expand All @@ -134,6 +178,20 @@
}
}

@include media-breakpoint-down(xs) {
float: none !important;
width: 100%;

[dir=ltr] & {
margin-right: 0;
}

[dir=rtl] & {
margin-right: 0;
margin-left: 0;
}
}

.js-stools-field-selector {
@include media-breakpoint-down(sm) {
max-width: 100%;
Expand All @@ -143,6 +201,15 @@
margin-right: 0;
}
}

@include media-breakpoint-down(xs) {
max-width: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already defined under media-breakpoint-down(sm)

margin-right: .5rem;

[dir=rtl] & {
margin-right: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already defined under media-breakpoint-down(sm)

}
}
}
}

Expand Down