-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Language manifest #27430
[4.0] Language manifest #27430
Conversation
After the language files were renamed the xml needs to be updated as well. (I still don't see why we have the files in here anyway but thats another topic)
build.xml
Outdated
@@ -156,8 +156,8 @@ | |||
</copy> | |||
<echo message="Copy language files" /> | |||
<mkdir dir="${basedir}/build/com_joomlaupdate-pkg/staging/admin/language" /> | |||
<copyfile src="${basedir}/administrator/language/en-GB/en-GB.com_joomlaupdate.ini" dest="${basedir}/build/com_joomlaupdate-pkg/staging/admin/language/en-GB.com_joomlaupdate.ini"/> | |||
<copyfile src="${basedir}/administrator/language/en-GB/en-GB.com_joomlaupdate.sys.ini" dest="${basedir}/build/com_joomlaupdate-pkg/staging/admin/language/en-GB.com_joomlaupdate.sys.ini"/> | |||
<copyfile src="${basedir}/administrator/language/en-GB/en-GB.com_joomlaupdate.ini" dest="${basedir}/build/com_joomlaupdate-pkg/staging/admin/language/en-GB/com_joomlaupdate.ini"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change in the src
attribute?
Agree with removing the prefix. However I also wonder why they are even there. I'm going to merge this by review. |
thanks |
* [4.0] Language manifest After the language files were renamed the xml needs to be updated as well. (I still don't see why we have the files in here anyway but thats another topic) * i think so
After the language files were renamed the xml needs to be updated as well. (I still don't see why we have the files in here anyway but thats another topic)
Testing Instructions
code review