[4.0] Search inputmode #27426
Merged
[4.0] Search inputmode #27426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mobile and touch devices will load a different keyboard depending on the inputmode. This is already implemented for several fields eg url and email This PR enables it for search fields As search fields are not a separate field type but type="text" we either have to create a new field type or it has to be added via the form xml. Support for the xml option was (surprisingly) already implemented so I just had to add the inputmode=search to the xml. To test this you will need either a mobile device or a touch enabled computer with a virtual keyboard. When you enter the search field you will see a slightly different keyboard than normal - the actual layout of which is dependent on your device. On my touch screen it looks like this
|
This is one of those ones it's probably worth backporting into staging. Thanks though! |
|
Thanks - happy to backport it |
Quy
reviewed
Jan 7, 2020
| @@ -287,7 +286,7 @@ public function save($data) | |||
| $isNew = true; | |||
|
|
|||
| // Include the plugins for the save events. | |||
| PluginHelper::importPlugin($this->events_map['save']); | |||
| \JPluginHelper::importPlugin($this->events_map['save']); | |||
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
Mobile and touch devices will load a different keyboard depending on the inputmode. This is already implemented for several fields eg url and email This PR enables it for search fields As search fields are not a separate field type but type="text" we either have to create a new field type or it has to be added via the form xml. Support for the xml option was (surprisingly) already implemented so I just had to add the inputmode=search to the xml. To test this you will need either a mobile device or a touch enabled computer with a virtual keyboard. When you enter the search field you will see a slightly different keyboard than normal - the actual layout of which is dependent on your device. On my touch screen it looks like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mobile and touch devices will load a different keyboard depending on the inputmode. This is already implemented for several fields eg url and email
This PR enables it for search fields
As search fields are not a separate field type but type="text" we either have to create a new field type or it has to be added via the form xml. Support for the xml option was (surprisingly) already implemented so I just had to add the inputmode=search to the xml.
To test this you will need either a mobile device or a touch enabled computer with a virtual keyboard.
When you enter the search field you will see a slightly different keyboard than normal - the actual layout of which is dependent on your device. On my touch screen it looks like this