Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Site Modules language alphasort #27424

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

brianteeman
Copy link
Contributor

c/s alpha sort site module strings

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jan 6, 2020
@Quy
Copy link
Contributor

Quy commented Jan 6, 2020

I have tested this item ✅ successfully on 4ee884c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27424.

@jwaisner
Copy link
Member

jwaisner commented Jan 6, 2020

@brianteeman Can you provide the test instructions? Is this just an overall test of functionality?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27424.

@brianteeman
Copy link
Contributor Author

Language strings should be sorted in alphabetical order. These were not. They are now. This is just a codestyle change. There is no functional difference

@jwaisner
Copy link
Member

jwaisner commented Jan 6, 2020

I have tested this item ✅ successfully on 4ee884c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27424.

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Jan 6, 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27424.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 6, 2020
@HLeithner HLeithner merged commit 698d113 into joomla:4.0-dev Jan 6, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 6, 2020
@HLeithner HLeithner added this to the Joomla 4.0 milestone Jan 6, 2020
@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the sitemodules branch January 6, 2020 22:46
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants