Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Custom-Select RTL #27387

Merged
merged 8 commits into from
Jan 7, 2020
Merged

[4.0] Custom-Select RTL #27387

merged 8 commits into from
Jan 7, 2020

Conversation

brianteeman
Copy link
Contributor

see screenshots for changes

If we wait for an expert to fix it then it will never happen

Before

image

After

image

@wilsonge
Copy link
Contributor

wilsonge commented Jan 4, 2020

@infograf768 can you confirm if this fixes things for you please?

@infograf768
Copy link
Member

@wilsonge
Will test asap, when I finish on searchtools

@infograf768
Copy link
Member

Works fine after correcting the small cs above.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 516d0d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27387.

@Quy
Copy link
Contributor

Quy commented Jan 6, 2020

I have tested this item ✅ successfully on f26ff83


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27387.

@Quy
Copy link
Contributor

Quy commented Jan 6, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27387.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 6, 2020
@infograf768 infograf768 merged commit 453159b into joomla:4.0-dev Jan 7, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 7, 2020
@infograf768
Copy link
Member

Tks.

@infograf768 infograf768 added this to the Joomla 4.0 milestone Jan 7, 2020
@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the select-rtl branch January 7, 2020 10:04
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
* image

* css

* Update administrator/templates/atum/scss/vendor/bootstrap/_custom-forms.scss

Co-Authored-By: Quy <quy@fluxbb.org>

* Update administrator/templates/atum/scss/vendor/bootstrap/_custom-forms.scss

Co-Authored-By: Quy <quy@fluxbb.org>

* Update _custom-forms.scss

Co-authored-by: Quy <quy@fluxbb.org>
Co-authored-by: infograf768 <infografjms@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants