Move a subform template out of the form scope, for IE compatibility #24947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on ab3b0a4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24947. |
1 similar comment
|
I have tested this item ✅ successfully on ab3b0a4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24947. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24947. |
|
@Fedik fix conflicts please. |
|
The only conflict is in the minified version of the js file. It shouldn't be necessary to have the author of the patch fix that. Ideally the minified file shouldn't even be committed in the first place. |
Conflicts: media/system/js/subform-repeatable.js
|
fixed |
|
@okonomiyaki3000 This is for Joomla 3 and we dont have anything setup to minify files for 3 - only j4 |
okonomiyaki3000
referenced
this pull request
May 23, 2019
* This is a combination of 8 commits. This is the 1st commit message: > First WIP version of supporting nested subforms. This is the commit message #2: > Fix nested subforms not getting correct name attribute on input fields. This is the commit message #3: > Fix subform rows having invalid index, fix small typo. This is the commit message #4: > Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process. This is the commit message #5: > Implement feedback from PR at Joomla; > - Use a <template> HTML element for the template of the subform rows, > not a url encoded string inside of a <script> element. > - Fix code style errors reported by phpcs. > - Make the fixing of the unique attributes (name, id, etc) of input elements > of nested subform rows more errorprone, using the same method as the main > subform row. > - Manually add a minified version of the javascript file. This is the commit message #6: > Fix failing javascript tests due to changed structure of subform repeatable template container. This is the commit message #7: > Change subform repeatable javascript test to correctly check on > 0-indexed rows, previously they have been 1-indexed. This is the commit message #8: > Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly. > Additionally added a note why the fixScripts() method is broken and how it could get better. * Commit code styling errors and add an aria label for the outermost 'add' button. * Fix double group-add button on repeatable subform type.
|
@Fedik I'm sorry, could you please resolve the conflict again? |
ghost
changed the title
Conflicts: media/system/js/subform-repeatable.js
|
fixed |
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #24832 for Joomla 3.x version
Same as #24944 but for staging.
Summary of Changes
This fix the subform field in IE, when one of subfield are required.
Testing Instructions
Please look for related issue for details.