Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for creating links to categories #20238

Closed
wants to merge 1 commit into from
Closed

Fix for creating links to categories #20238

wants to merge 1 commit into from

Conversation

AlekVolsk
Copy link

Before applying the option, check its existence to inadvertently nothing promolast

Before applying the option, check its existence to inadvertently nothing promolast
@alikon
Copy link
Contributor

alikon commented Apr 25, 2018

can you test #20229 please ?

@AlekVolsk
Copy link
Author

Look at your own code: do you check the parameter for an empty string, but have you seen what the default parameter is? And by default there is no parameter at all, it is equal to NULL. You're in the next pull-requests staged the whole study about anything, they themselves are breaking use of a private API. How do you even work? I do not understand...

@Septdir
Copy link
Contributor

Septdir commented Apr 25, 2018

@AlekVolsk напишу по-русски во первых исправление уже давно готово в #20229

35f8ac0

Во вторых у тебя тут тоже ошибка. Если получать layout так то получиться
templatelayout а должно быть template:layout

Я тоже сначала пытался решить это проблему подобным фиксом в #20200 Затем увидев что проблема куда глубже пытался сделать откат в #20211 Ну а в итоге получилось вот так #20229

P.S учитесь пользоваться поиском

@AlekVolsk AlekVolsk closed this Apr 25, 2018
@AlekVolsk AlekVolsk deleted the patch-1 branch April 25, 2018 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants