Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statistics in mod_stats (front end) depending on the event "onGetStats" #15998

Closed
wants to merge 1 commit into from

Conversation

astridx
Copy link
Contributor

@astridx astridx commented May 13, 2017

Summary of Changes

I added showing statistics in mod_stats (front end) depending on the event "onGetStats".
And I deleted the fix way, web links counted the stats.
mod_stats_admin used the event "onGetStats" already.

Testing Instructions

  1. Install web links https://github.com/joomla-extensions/weblinks/releases

  2. Create a web link and a menu item for showing the web link per category.

  3. Open frond end and click the web link so stats are collected.

  4. Create a module that shows statistics in frond end and select hit counter. Select a position for this module and show it on all pages.

  5. Navigate to the front page and see, that the stats for web links are shown

  6. Navigate to the plugin manager and see, that the plugin System - Web Links is not active

  7. Apply my patch and see, that stats are shown if the plugin is active and they are not shown, if the plugin is not active.

Expected result

If the plugin System - Web Links is not active, there should no stats are shown.

Actual result

Stats are shown in the front end for the component web links independent of the plugin System - Web Links.
If another component used the event "onGetStats", these stats are only shown in the back end module
mod_stats_admin and not in the frond end module mod_stats.

@astridx astridx changed the title useplugininstatsmoduleforfrontend Add statistics in mod_stats (front end) depending on the event "onGetStats" May 13, 2017
@astridx
Copy link
Contributor Author

astridx commented May 13, 2017

Close because of duplicated: #15138

@astridx astridx closed this May 13, 2017
@ghost ghost mentioned this pull request May 23, 2017
@astridx astridx deleted the statsfrontend branch February 18, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants