-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make codemirror compatible with scss #14485
Conversation
@@ -31,6 +31,7 @@ class PlgEditorCodemirror extends JPlugin | |||
* @var array | |||
*/ | |||
protected $modeAlias = array( | |||
'scss' => 'css', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the ocd in me says that this should go at the end of the array to maintain alphabetical order/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course it does ;)
thanks
I have tested this item ✅ successfully on 4e1763d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14485. |
1 similar comment
I have tested this item ✅ successfully on 4e1763d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14485. |
RTC as there are 2 successfully Tests? |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14485. |
Pull Request for Issue # .
Summary of Changes
Info: https://codemirror.net/mode/css/scss.html
Testing Instructions
Make sure you have some scss files in one of your template,
Try to edit this file, observe the console and the text inside the editor
Before
After
Documentation Changes Required
None