Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make codemirror compatible with scss #14485

Merged
merged 2 commits into from
Mar 15, 2017
Merged

Make codemirror compatible with scss #14485

merged 2 commits into from
Mar 15, 2017

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Mar 11, 2017

Pull Request for Issue # .

Summary of Changes

  • Remove error on template scss file edit
  • Beautify the contents of an scss file

Info: https://codemirror.net/mode/css/scss.html

Testing Instructions

Make sure you have some scss files in one of your template,
Try to edit this file, observe the console and the text inside the editor

Before

screen shot 2017-03-11 at 11 44 38

After

screen shot 2017-03-11 at 11 45 01

Documentation Changes Required

None

@@ -31,6 +31,7 @@ class PlgEditorCodemirror extends JPlugin
* @var array
*/
protected $modeAlias = array(
'scss' => 'css',
Copy link
Contributor

@brianteeman brianteeman Mar 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ocd in me says that this should go at the end of the array to maintain alphabetical order/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course it does ;)

thanks

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 4e1763d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14485.

1 similar comment
@ghost
Copy link

ghost commented Mar 13, 2017

I have tested this item ✅ successfully on 4e1763d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14485.

@ghost
Copy link

ghost commented Mar 14, 2017

RTC as there are 2 successfully Tests?

@jeckodevelopment
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14485.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 15, 2017
@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Mar 15, 2017
@rdeutz rdeutz merged commit 79ace20 into joomla:staging Mar 15, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 15, 2017
Bakual pushed a commit that referenced this pull request Mar 16, 2017
@dgrammatiko dgrammatiko deleted the patch-10 branch April 10, 2017 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants