Debug permissions in com_users #14408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… users and groups view. The defaullt is to on
If not set then it defaults to ON Change the IF statement use to turn on the display of the debug link to use the param instead of the JDEBUG
If not set then it defaults to ON
…to use the param instead of the JDEBUG
Add missing Options button from toolbar
Simplify parameter checks
|
I have tested this item ✅ successfully on 1fff9dd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14408. |
|
I have tested this item ✅ successfully on 1fff9dd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14408. |
|
@Bakual can you fix conflicts, please? |
|
Back to Pending due to conflicting files. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14408. |
|
@jeckodevelopment Conflicts are solved now. |
|
I have tested this item ✅ successfully on fab4401 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14408. |
|
I have tested this item ✅ successfully on fab4401 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14408. |
Just some smal CS fixes for 14408
|
I have tested this item ✅ successfully on 2555c79 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14408. |
1 similar comment
|
I have tested this item ✅ successfully on 2555c79 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14408. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14408. |
rdeutz
pushed a commit
that referenced
this pull request
Mar 10, 2017
* Add a fieldset in the component config to support disabling the debug users and groups view. The defaullt is to on * Add code to read the params from the config.xml If not set then it defaults to ON Change the IF statement use to turn on the display of the debug link to use the param instead of the JDEBUG * Add code to read the params from the config.xml If not set then it defaults to ON * Change the IF statement use to turn on the display of the debug link to use the param instead of the JDEBUG * fix the params IF statement * Fix the params fallback * Add language strings * Add missing Cancel button from toolbar (replaces PR14384) Add missing Options button from toolbar * Simplify param check * Simplify param check #2 * change the strings from debug to advanced * fix toolbar permissions check * Update config.xml * Update default.php * Update default.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a very nice and helpful view for "debugging" issues with user permissions. But that view is only available when "Debug System" is enabled in the global configuration. If it's disabled (like in normal production) the link to it is hidden.
Summary of Changes
This PR adds two new options in the user manager which will allow to enable/disable that
"Debug""Advanced" view for the user and usergroup manager. Making the view more known.The new options are enabled by default since there is no drawback to have them enabled. It's just a link shown. Also it will be B/C for those who had Debug enabled for whatever reason.
Testing Instructions
Expected result
Have a link to those views not depending on Debug status.
Actual result
Links only shown when Debug is active.
Documentation Changes Required
Maybe tutorials need to be adjusted.
Disclaimer
Work is done by @brianteeman