Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced unnecessary double quotes in plugins #13211

Merged
merged 2 commits into from
Dec 18, 2016
Merged

Replaced unnecessary double quotes in plugins #13211

merged 2 commits into from
Dec 18, 2016

Conversation

frankmayer
Copy link
Contributor

Summary of Changes

  • Replaced unnecessary double quotes in plugins

This PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for plugins, which is still on hold (#12228).
Once the new set is merged it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.

The changes in this PR are few and very easy to review. In hope that this will get merged quickly. ;)

Testing Instructions

None, should not change behavior

Documentation Changes Required

None.

@@ -51,10 +51,10 @@ protected function getLabel()

// Add CSS and JS for the TOS field
$doc = JFactory::getDocument();
$css = "#jform_profile_tos {width: 18em; margin: 0 !important; padding: 0 2px !important;}
$css = '#jform_profile_tos {width: 18em; margin: 0 !important; padding: 0 2px !important;}
#jform_profile_tos input {margin:0 5px 0 0 !important; width:10px !important;}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space after margin: and width: in two lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it.

@wilsonge wilsonge merged commit cc93105 into joomla:staging Dec 18, 2016
@wilsonge wilsonge added this to the Joomla 3.7.0 milestone Dec 18, 2016
@frankmayer frankmayer deleted the unnecessary-double-quotes-in-plugins branch December 25, 2016 21:49
@frankmayer frankmayer mentioned this pull request Jan 6, 2017
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants