Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance 4 (plugins) #12228

Merged
merged 42 commits into from
Jun 8, 2017
Merged

Performance 4 (plugins) #12228

Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
d020e05
Use Elvis instead of full ternary
frankmayer Sep 29, 2016
f8d247c
Use prefixed increment instead of assignment
frankmayer Sep 29, 2016
bcd8841
Use single quotes instead of doublequotes
frankmayer Sep 29, 2016
e1288c3
Remove unnecessary parentheses
frankmayer Sep 29, 2016
fdd996c
Replace alias function with original
frankmayer Sep 29, 2016
dfc5b98
Remove useless return
frankmayer Sep 29, 2016
aac1916
Removed unnecessary ternary operators
frankmayer Sep 29, 2016
90ffc54
Fixed callable call in loop termination condition
frankmayer Sep 29, 2016
a9d98bd
Replace is_null() with ... === null
frankmayer Sep 29, 2016
33ba088
Shortened syntax for applied operations
frankmayer Sep 29, 2016
5c7afbf
Don't use strlen() to check if string is empty.
frankmayer Sep 29, 2016
9a1a4b6
Replace strstr() with strpos()
frankmayer Sep 29, 2016
a8f2a36
Replace substr() with strpos()
frankmayer Sep 29, 2016
a158cae
Merge unset()
frankmayer Sep 29, 2016
b3da6e9
Inline one-time use variables
frankmayer Sep 29, 2016
58b8fbb
Type safe string comparison
frankmayer Sep 29, 2016
8f28982
Remove unused variable
frankmayer Sep 29, 2016
776666b
Merge if statements into parents
frankmayer Sep 29, 2016
7b70c06
Optimize non-optimal if conditions.
frankmayer Sep 29, 2016
af3e78b
More type-safe comparisons
frankmayer Sep 29, 2016
f5fc398
Fix another non-optimal if condition
frankmayer Sep 30, 2016
ac4921a
Merged another str_replace() case
frankmayer Sep 30, 2016
6f79ff1
Fix own typo
frankmayer Sep 30, 2016
943f500
Fix formatting
frankmayer Sep 30, 2016
ac0ebb4
Further optimize an if condition
frankmayer Sep 30, 2016
b9adbc5
Fix codesniffer
frankmayer Sep 30, 2016
42a5a54
Fixes...
frankmayer Oct 4, 2016
9e8063e
Changes, based on discussions with @csthomas
frankmayer Dec 9, 2016
492fb9e
One more change, based on previous discussion.
frankmayer Dec 10, 2016
475b880
Merge branch 'staging' into Performance_4
frankmayer Dec 10, 2016
7edf386
A few more minor fixes
frankmayer Dec 10, 2016
5e7202b
Fix slipped through merge conflict
frankmayer Dec 10, 2016
9581e65
Correction in comparison
frankmayer Dec 10, 2016
d0d9261
Correction in comparison with trim result
frankmayer Dec 10, 2016
bea9c0b
Merge branch 'staging' of https://github.com/joomla/joomla-cms into P…
frankmayer Dec 18, 2016
bf361ca
Merge branch 'staging' into Performance_4
frankmayer Dec 19, 2016
b7636dc
Reverted this one to not clash with @laoneo's refactoring efforts
frankmayer Dec 29, 2016
755c648
Merge branch 'staging' into Performance_4
frankmayer May 29, 2017
8afee4f
Merge branch 'staging' into Performance_4
frankmayer May 31, 2017
5f011db
Some changes according to reviewer's comments
frankmayer Jun 1, 2017
76fe7a9
Some changes according to reviewer's comments
frankmayer Jun 1, 2017
33d7bd2
Additional changes according to reviewer's comments
frankmayer Jun 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions plugins/system/fields/fields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,8 @@ public function onContentPrepare($context, $item)
{
$item->fields[$field->id] = $field;
}

return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted this one to its prior state, so it won't raise conflicts with @laoneo 's efforts.

}

/**
Expand Down Expand Up @@ -501,7 +503,7 @@ public function onPrepareFinderContent($item)
}

// Transofrm com_article to com_content
if ($component === 'com_article')
if ($component == 'com_article')
{
$component = 'com_content';
}
Expand Down Expand Up @@ -565,7 +567,7 @@ private function getParts($context)
return null;
}

if ($parts[1] === 'form')
if ($parts[1] == 'form')
{
// The context is not from a known one, we need to do a lookup
// @todo use the api here.
Expand Down