Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Summer of Code 2016 JavaScript Testing project: Tests for combobox.js library. #11810

Merged
merged 2 commits into from
Aug 27, 2016

Conversation

Ruchiranga
Copy link
Contributor

@Ruchiranga Ruchiranga commented Aug 26, 2016

Pull Request extending #11420 by adding tests written for combobox.js library.

Summary of Changes

This PR includes a new set of test cases written for the combobox.js JavaScript library of Joomla!.

Testing Instructions

None, since this is only run on Travis. If you want to run it locally, please take a look at the documentation available here.

@zero-24
Copy link
Contributor

zero-24 commented Aug 26, 2016

@Ruchiranga can we change the doc blocks similiar to ther other doc blocks?

@zero-24
Copy link
Contributor

zero-24 commented Aug 26, 2016

/**
 * @package     Joomla.Tests
 * @subpackage  JavaScript Tests
 *
 * @copyright   Copyright (C) 2005 - 2016 Open Source Matters, Inc. All rights reserved.
 * @license     GNU General Public License version 2 or later; see LICENSE.txt
 *
 * @since       __DEPLOY_VERSION__
 * @version     1.0.0
 */

@Ruchiranga
Copy link
Contributor Author

@zero-24 done.

@zero-24
Copy link
Contributor

zero-24 commented Aug 26, 2016

Thanks @Ruchiranga 👍

@zero-24
Copy link
Contributor

zero-24 commented Aug 26, 2016

I have tested this item ✅ successfully on 73b7a46

travis is ok. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11810.

@yvesh
Copy link
Member

yvesh commented Aug 26, 2016

I have tested this item ✅ successfully on f73b0c4


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11810.

@zero-24
Copy link
Contributor

zero-24 commented Aug 26, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11810.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 26, 2016
@brianteeman brianteeman added this to the Joomla 3.6.3 milestone Aug 26, 2016
@rdeutz rdeutz merged commit fc38165 into joomla:staging Aug 27, 2016
@brianteeman
Copy link
Contributor

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants