Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newsfeed intro image [redo] #11687

Closed
wants to merge 7 commits into from
Closed

newsfeed intro image [redo] #11687

wants to merge 7 commits into from

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Aug 20, 2016

Pull Request for Issue #11402 .
redo for @rdeutz as it was merged in the wrong brach

$image = preg_match('/http/', $introImage)? $introImage : JURI::root() . $introImage;
$item->description = '<p><img src="' . $image . '" /></p>';
}
$item->description .= ($params->get('feed_summary', 0) ? $item->introtext . $item->fulltext : $item->introtext);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need a new line after the closing if braces :-) (in view.feed.php too)

@brianteeman
Copy link
Contributor Author

This PR was RTC and was merged by @rdeutz into the wrong branch so I had to redo it

@brianteeman
Copy link
Contributor Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11687.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 20, 2016
@wilsonge
Copy link
Contributor

wilsonge commented Sep 4, 2016

Merged with 4058aa6

@wilsonge wilsonge closed this Sep 4, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 4, 2016
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the new_newsfeed branch September 4, 2016 13:40
@rdeutz rdeutz modified the milestones: Joomla 3.6.3, Joomla 3.7.0 Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants