Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color field using JLayouts #11030

Closed
wants to merge 4 commits into from
Closed

Color field using JLayouts #11030

wants to merge 4 commits into from

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Jul 5, 2016

Use JLayout for the html output

Summary of Changes

  • Split the layout to 2: simple and advanced
  • Added relevant script files for the initialisation (static files @ media/system/js)
  • Deprecated the Html::behaviour.simplecolorpicker and Html::behaviour.colorpicker

Testing Instructions

To test edit isis template xml and add:

                <field name="color"
                       class=""
                       type="color"
                       default="#1A3867"
                       validate="color"
                        control=""
                       label="color: " />

Changing control to control="simple" you initiate the simple mode, the advanced is the default.

Preview

Simple mode:
screen shot 2016-07-05 at 23 14 17

Advanced mode:
screen shot 2016-07-05 at 23 14 12

@RonakParmar
Copy link

Do I have to do anything extra to test this PR except applying this PR?
I have added above color code field in template.xml and works fine with applying PR, but when I have applied PR got javascript error. Please see screen dump of error.
screen shot 2016-07-06 at 00 56 36


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030.

@RonakParmar
Copy link

I have tested this item ✅ successfully on 40b09b8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030.

* @var boolean $repeat Allows extensions to duplicate elements.
* @var boolean $required Is this field required?
* @var integer $size Size attribute of the input.
* @var boolean $spellchec Spellcheck state for the form field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing "k" in spellcheck ... ;-)
(i've seen this typo error in your latest PRs too)

@cyrezdev
Copy link
Contributor

cyrezdev commented Jul 7, 2016

I have tested this item successfully, but i can't mark it on joomla issue tracker as i can't access the website since this morning, telling me "You are a terrible, terrible person." 😞
But i'm not!
@mbabker maybe you can help me ? I don't know who to contact to know why my IP is blocked from accessing issue tracker ?

Note: it happened 2 hours ago, while opening the issue tracker site on my iPhone...

@brianteeman
Copy link
Contributor

@JoomliC - everyone has that problem right now - its a server issue we are waiting a fix for

@cyrezdev
Copy link
Contributor

cyrezdev commented Jul 7, 2016

@brianteeman Thanks! Good to know my mobile is ok ;-)

@nikitadhiman
Copy link

I have tested this item ✅ successfully on 40b09b8

This is good :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030.

@cyrezdev
Copy link
Contributor

cyrezdev commented Jul 7, 2016

I have tested this item ✅ successfully on 40b09b8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 7, 2016
@brianteeman brianteeman modified the milestone: Joomla 3.7.0 Jul 11, 2016
wilsonge pushed a commit that referenced this pull request Jul 30, 2016
@wilsonge
Copy link
Contributor

Merged with 6aeb68b - thanks!

@wilsonge wilsonge closed this Jul 30, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 30, 2016
@dgrammatiko dgrammatiko deleted the +FieldColor branch October 11, 2016 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants