Make JAuthentication autoloaded, split 2 classes to 2 files #11023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1424,6 +1424,8 @@ public function deleteUnexistingFiles() | |||
| '/administrator/templates/isis/js/jquery.js', | |||
| '/administrator/templates/isis/js/bootstrap.min.js', | |||
| '/media/system/js/permissions.min.js', | |||
| // Joomla __DEPLOY_VERSION__ | |||
There was a problem hiding this comment.
this (#10883) needs to be merged for __DEPLOY_VERSION__ to work
There was a problem hiding this comment.
I'm counting on that being merged before this PR ever makes it to a stable release 😉
|
I have tested this item ✅ successfully on 3233daa This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11023. |
|
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11023. |
|
I have tested this item ✅ successfully on 3233daa This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11023. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11023. |
|
Merged with 761bf53 - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The
JAuthenticationclass requires manual import and the file that holds this class contains two classes (JAuthenticationandJAuthenticationResponse). Move the file so it can be autoloaded and split the response class to a new file to follow the one class per file convention.Testing Instructions
User authentication still works correctly, on update the old file is deleted.