Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Reorganise administrator menu items - extensions manager #10657

Closed
wants to merge 8 commits into from

Conversation

izharaazmi
Copy link
Contributor

@izharaazmi izharaazmi commented May 28, 2016

Summary of Changes

Reorganised the menu items under the extension manager top level menu item. As seen in the past few release we are no longer supporting Joomla core update via extensions manager, that is a good move. Having a good explanation from @brianteeman and @mbabker I was convinced well that these two need to operate independently with no internal handovers.

However, I can understand the annoyance caused to Brian and Michael explaining this to everyone separately over and again. I suggest to make some visual change that calls for the users' action.

With this reorganisation, people would feel that there is some change right there. Investing little they would be able to see both options alongside and tend more towards using appropriate option rather than assuming "I did it before, why not now!".

Testing Instructions

  • New testers only: Please follow the testing instructions at Testing Joomla! patches
  • Every link should open the correct page.
  • Changing permissions on 'com_joomlaupdate', 'com_postinstall' and 'com_installer' should hide the respective menu items correctly.

PS: Asking for password on Joomla Update seems unnecessary and annoying as well. If we really want to be sure it could be just a confirm checkbox or a button. Irrelevant here.

…e distinguishable at the first sight. Lets not confuse people showing thing same visually, but changing things internally.
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels May 28, 2016
@izharaazmi
Copy link
Contributor Author

Old menu looked like:

image

image

With this PR they look like:

image
image
image

@brianteeman
Copy link
Contributor

brianteeman commented May 28, 2016 via email

@izharaazmi
Copy link
Contributor Author

izharaazmi commented May 28, 2016

That would be better. J3.6 itself or leave it for 3.7!

@brianteeman
Copy link
Contributor

brianteeman commented May 28, 2016 via email

@izharaazmi
Copy link
Contributor Author

izharaazmi commented May 28, 2016

Wow! That's my Sunday treat 👍 I'll surely read all that tomorrow and make up my mind around.

Well, in that case we may consider this small change for now. Right?

@zafarnayab
Copy link

I have tested this item ✅ successfully on a2bfff3

I've tested this .
It works Successfully...
All link works Perfectly same as it works before Patched.

While revoking Permission on 'com_joomlaupdate', 'com_postinstall' and 'com_installer' it hidden for the respective User.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @zafarnayab


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

@izharaazmi
Copy link
Contributor Author

Can we remove label "Language Change" as this no longer requires one!

@brianteeman
Copy link
Contributor

Removed as requested (note it is still too late for 3.6)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

@brianteeman brianteeman removed the Language Change This is for Translators label Jun 19, 2016
@izharaazmi
Copy link
Contributor Author

izharaazmi commented Jun 19, 2016

Well, if protocols says I must obey.

May I ask under which specific reason this is late, coz IMO, this is just a reorganisation of existing menu items only. No additions, no removal of anything at all and no b/c break, no new feature. Just visual change.

I assumed the language freeze was the issue, hence I modified. I must be missing something, please enlighten me.

About the backend menu manager (i had a look at #5492), it sounds great to me and that I'd gladly work on if suggested/assigned to. And that I think is too late for now and should be considered only for J3.7.

@brianteeman
Copy link
Contributor

re #5492 I really want to see that happen so any help i can give you I will

re this PR my understanding that as we are in beta stage then we are
"feature complete" see
https://developer.joomla.org/news/586-joomla-development-strategy.html

Maybe @wilsonge can expand on that

On 19 June 2016 at 11:39, Izhar Aazmi notifications@github.com wrote:

Well, if protocols says I must obey.

May I ask under which specific reason this is late, coz IMO, this is just
a reorganisation of existing menu items only. No additions, no removal
of anything at all and no b/c break, no new feature. Just visual change.

I assumed the language freeze was the issue, hence I modified. I must me
missing something, please enlighten me.

About the backend menu manager (i had a look at #5492
#5492), it sounds great to
me and that I'd gladly work if suggested/assigned to. And that I think is
too late for now and should be considered only for J3.7.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10657 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8U0mxwppI0y72Zxi_HSchvwxVomJks5qNRxvgaJpZM4IpGX7
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@izharaazmi
Copy link
Contributor Author

IMO, this is not even a feature, however if you think so.
This could be really helpful to people messing with the new Joomla update method vs extension installer.

For #5492. I'll soon get into a strategy as well as some programming based on the discussion there plus my understanding. I'll get back to you as and when needed.

@ghost
Copy link

ghost commented Jun 19, 2016

I have tested this item 🔴 unsuccessfully on 1b0008c

Firefox. Staging staging 2016-06-16.
Applied patch. Clicked on Manage. Clicked on System. First level closes. Second level remains open.

19-06-_2016_15-11-40

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @bertmert, @zafarnayab


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

@ghost
Copy link

ghost commented Jun 19, 2016

I have tested this item 🔴 unsuccessfully on 967145d

Problems with mobile menu.

Resize window or use mobile device to see mobile menu.

Tip Extensions. That's OK because you have the sidebar menu in next view.
19-06-_2016_17-12-04

Tip System. That's not OK because this is a "dead end street".

19-06-_2016_17-16-24

@izharaazmi
Copy link
Contributor Author

izharaazmi commented Jun 19, 2016

@bertmert This PR does not add anything different that is not already in
the cms.
Does it work as expected before this patch? Waiting for your images and
description.

Thanks.

@ghost
Copy link

ghost commented Jun 19, 2016

See edits above.

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 967145d

I confirm the findings of @bertmert


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

@NeerajTailored
Copy link

I have tested this item ✅ successfully on 967145d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

@JamalTailored
Copy link

I have tested this item ✅ successfully on 967145d

Tested using joomla staging branch


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

…avoid component level collision and dependency.
@izharaazmi
Copy link
Contributor Author

izharaazmi commented Apr 11, 2017 via email

@infograf768
Copy link
Member

A bit too late imho for 3.7.0. Has to be considered for 3.7.1 or 3.8

@ghost
Copy link

ghost commented Apr 11, 2017

I have tested this item ✅ successfully on 740cfec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10657.

1 similar comment
@Gavakshi
Copy link
Contributor

I have tested this item ✅ successfully on 740cfec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10657.

@jeckodevelopment
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10657.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 12, 2017
@brianteeman
Copy link
Contributor

This is a big change in the UI and should not be just set to RTC based on two tests that it works

@rdeutz rdeutz added this to the Joomla 3.8.0 milestone Apr 12, 2017
@mbabker
Copy link
Contributor

mbabker commented May 21, 2017

My first thought here is let's do this in 4.0 and leave potentially major workflow related changes alone in 3.x in favor of stability at this point (and moving menu items is a major workflow change).

@brianteeman
Copy link
Contributor

I agree

@tonypartridge
Copy link
Contributor

Agreed this should be moved to V4. Users won't be pleased with this change in 3.x since it's quite a workflow change.

But I think it's a great idea.

@mbabker mbabker modified the milestones: Joomla 4.0, Joomla 3.8.0 Jul 1, 2017
@mbabker
Copy link
Contributor

mbabker commented Jul 1, 2017

Moved to 4.0 milestone for reasons stated above.

@joomla-cms-bot joomla-cms-bot changed the title Reorganise administrator menu items - extensions manager [4.0] Reorganise administrator menu items - extensions manager Oct 27, 2017
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Oct 27, 2017
@ghost
Copy link

ghost commented Oct 27, 2017

please reassign Milestone 4.0, thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10657.

@infograf768 infograf768 added this to the Joomla 4.0 milestone Oct 27, 2017
@ghost
Copy link

ghost commented Oct 30, 2017

@izharaazmi can you please resolve conflicting Files?

@brianteeman
Copy link
Contributor

I would wait for the results of the UX team research into the menus

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Jan 17, 2018
@brianteeman brianteeman added this to the Joomla 4.0 milestone Mar 17, 2018
@roland-d
Copy link
Contributor

Are we ready to move on this?

@brianteeman
Copy link
Contributor

Well the template team still havent completed the menu and have arbitrarily reassigned the menus etc so I guess not

@wilsonge
Copy link
Contributor

wilsonge commented Aug 1, 2018

Now we have the configurable admin menu and a different structure in J4 I'm going to close this for now (it totally conflicts anyhow with the xml structure for admin menus - so it would need to be completely redone to test anyhow). We can create a new version if people still feel this is a good idea later on.

@wilsonge wilsonge closed this Aug 1, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.