-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Reorganise administrator menu items - extensions manager #10657
Conversation
…e distinguishable at the first sight. Lets not confuse people showing thing same visually, but changing things internally.
I much prefer that we don't continue with hard coding the admin menu and
finally have a real admin menu manager that is configurable
|
That would be better. J3.6 itself or leave it for 3.7! |
Too late for 3.6 please see #5492
|
Wow! That's my Sunday treat 👍 I'll surely read all that tomorrow and make up my mind around. Well, in that case we may consider this small change for now. Right? |
I have tested this item ✅ successfully on a2bfff3 While revoking Permission on 'com_joomlaupdate', 'com_postinstall' and 'com_installer' it hidden for the respective User. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657. |
This PR has received new commits. CC: @zafarnayab This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657. |
Can we remove label "Language Change" as this no longer requires one! |
Removed as requested (note it is still too late for 3.6) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657. |
Well, if protocols says I must obey. May I ask under which specific reason this is late, coz IMO, this is just a reorganisation of existing menu items only. No additions, no removal of anything at all and no b/c break, no new feature. Just visual change. I assumed the language freeze was the issue, hence I modified. I must be missing something, please enlighten me. About the backend menu manager (i had a look at #5492), it sounds great to me and that I'd gladly work on if suggested/assigned to. And that I think is too late for now and should be considered only for J3.7. |
re #5492 I really want to see that happen so any help i can give you I will re this PR my understanding that as we are in beta stage then we are Maybe @wilsonge can expand on that On 19 June 2016 at 11:39, Izhar Aazmi notifications@github.com wrote:
Brian Teeman |
IMO, this is not even a feature, however if you think so. For #5492. I'll soon get into a strategy as well as some programming based on the discussion there plus my understanding. I'll get back to you as and when needed. |
I have tested this item 🔴 unsuccessfully on 1b0008c |
This PR has received new commits. CC: @bertmert, @zafarnayab This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657. |
I have tested this item 🔴 unsuccessfully on 967145d Resize window or use mobile device to see mobile menu. Tip Extensions. That's OK because you have the sidebar menu in next view. Tip System. That's not OK because this is a "dead end street". |
@bertmert This PR does not add anything different that is not already in Thanks. |
See edits above. |
I have tested this item 🔴 unsuccessfully on 967145d This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657. |
I have tested this item ✅ successfully on 967145d This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657. |
I have tested this item ✅ successfully on 967145d This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657. |
…avoid component level collision and dependency.
Yes
|
A bit too late imho for 3.7.0. Has to be considered for 3.7.1 or 3.8 |
I have tested this item ✅ successfully on 740cfec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10657. |
1 similar comment
I have tested this item ✅ successfully on 740cfec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10657. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10657. |
This is a big change in the UI and should not be just set to RTC based on two tests that it works |
My first thought here is let's do this in 4.0 and leave potentially major workflow related changes alone in 3.x in favor of stability at this point (and moving menu items is a major workflow change). |
I agree |
Agreed this should be moved to V4. Users won't be pleased with this change in 3.x since it's quite a workflow change. But I think it's a great idea. |
Moved to 4.0 milestone for reasons stated above. |
please reassign Milestone 4.0, thanks. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10657. |
@izharaazmi can you please resolve conflicting Files? |
I would wait for the results of the UX team research into the menus |
Are we ready to move on this? |
Well the template team still havent completed the menu and have arbitrarily reassigned the menus etc so I guess not |
Now we have the configurable admin menu and a different structure in J4 I'm going to close this for now (it totally conflicts anyhow with the xml structure for admin menus - so it would need to be completely redone to test anyhow). We can create a new version if people still feel this is a good idea later on. |
Summary of Changes
Reorganised the menu items under the extension manager top level menu item. As seen in the past few release we are no longer supporting Joomla core update via extensions manager, that is a good move. Having a good explanation from @brianteeman and @mbabker I was convinced well that these two need to operate independently with no internal handovers.
However, I can understand the annoyance caused to Brian and Michael explaining this to everyone separately over and again. I suggest to make some visual change that calls for the users' action.
With this reorganisation, people would feel that there is some change right there. Investing little they would be able to see both options alongside and tend more towards using appropriate option rather than assuming "I did it before, why not now!".
Testing Instructions
PS: Asking for password on Joomla Update seems unnecessary and annoying as well. If we really want to be sure it could be just a confirm checkbox or a button.Irrelevant here.