Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[html5] System frontend template #10641

Closed
wants to merge 2 commits into from
Closed

[html5] System frontend template #10641

wants to merge 2 commits into from

Conversation

andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented May 26, 2016 •
edited by joomla-cms-bot
Loading

Summary of Changes

This is a redo of #9842 for system site only.

This PR does a basic conversion of system site template to HTML5.
Also made some minor corrections:

  • Use the API in inline css/js (except error page)
  • Use ie9 or lower hml5.js in all files.

Testing Instructions

 $this->template = new stdClass;
 $this->template->template = 'system';
 $this->template->params   = new Registry;
  • Go to frontend and check if the the following pages are working properly (they don't have style):
    • component popup (add ?tmpl=component&print=1 to an existent page)
    • error pages (test one non existent URL)
    • offline (set the site to offline and check the login page)
  • Remove the code added in 2. and check all is again ok and with style.

Check also the code changes.

Observations

All pages should now start with this code:

<!DOCTYPE html>
<html lang="en-gb" dir="ltr">
<head>
[...]
    <meta charset="utf-8" />
[...]

@RonakParmar
Copy link

I have tested this item 🔴 unsuccessfully on e4834ef

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.

@RonakParmar
Copy link

screen shot 2016-07-01 at 07 47 54

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.

@mbabker
Copy link
Contributor

mbabker commented Jul 1, 2016

What's the issue? The system templates don't really have any of their own styling for general use. Here you're mainly focused on the actual HTML output and that there aren't any errors versus the visual aesthetics.

@andrepereiradasilva
Copy link
Contributor Author

@RonakParmar that is not a problem. it works like that.

@RonakParmar
Copy link

I have applied this PR and added above code in given path file and line number.
Here is the screen-shots of my site before PR apply and after PR and above code applied.
screen shot 2016-07-08 at 06 44 40screen shot 2016-07-08 at 06 44 45

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.

@RonakParmar
Copy link

First screen-shot is after PR applied and code added.
Second screen-shot is before PR apply.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.

@mbabker
Copy link
Contributor

mbabker commented Jul 8, 2016

Without hacking core, you can't use the system template for general use (except the error.php layout because of a hardcoded fallback). So the fact your before screenshot is using Protostar tells me you don't have a hack in place to force the system template.

@andrepereiradasilva
Copy link
Contributor Author

@RonakParmar the code in the test instructions is exactly to force the system template (you can't select the system template in templates so we need to do this).

so for me it seems your test (first print screen) is a success.

@RonakParmar
Copy link

@andrepereiradasilva So, After adding that code my site is not working properly, Is it successful test?

@andrepereiradasilva
Copy link
Contributor Author

yes, remove the custom code added and you will see it's working correctly with the patch applied.

@RonakParmar
Copy link

Okay, testing. Thanks for the update.

@RonakParmar
Copy link

Yes, without the code added, this PR works fine.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.

@RonakParmar
Copy link

Please mention that, after removing the code front-end will work fine, in testing instruction, so people like me get idea and otherwise they perform same thing that I have done. :)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.

@RonakParmar
Copy link

I have tested this item ✅ successfully on e4834ef

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.

@andrepereiradasilva
Copy link
Contributor Author

added to test instructions, thanks

@AnishaTailored
Copy link

I have tested this item ✅ successfully on e4834ef

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.

@gunjanpatel
Copy link
Contributor

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 11, 2016
@roland-d roland-d added this to the Joomla 3.7.0 milestone Jul 16, 2016
wilsonge added a commit that referenced this pull request Sep 3, 2016
@wilsonge
Merge branch 'system_frontend_html5' into 3.7.x. Fixes #10641
51a23f8
@wilsonge
Copy link
Contributor

wilsonge commented Sep 3, 2016

Merged with 51a23f8

@wilsonge wilsonge closed this Sep 3, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 3, 2016
@andrepereiradasilva andrepereiradasilva deleted the html5-system-site branch September 3, 2016 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Joomla 3.7.0
Development

Successfully merging this pull request may close these issues.
8 participants
@andrepereiradasilva @RonakParmar @mbabker @AnishaTailored @gunjanpatel @wilsonge @roland-d @joomla-cms-bot