Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs: SyntaxError: missing } after property list #421

Closed
compojoom opened this issue Sep 20, 2012 · 1 comment
Closed

Tabs: SyntaxError: missing } after property list #421

compojoom opened this issue Sep 20, 2012 · 1 comment

Comments

@compojoom
Copy link
Contributor

I'm using the jhtmltabs class in the backend this generates the following js error:
SyntaxError: missing } after property list

Looking at the generated code:

new JTabs(tabs, { useStorage: 'false', titleSelector: ''dt.tabs'', descriptionSelector: ''dd.tabs''});

as you can see we have double single quotes and that is not valid js.

this is generated in html\tabs.php on line 88 and 89:

        $opt['titleSelector']       = "'dt.tabs'";
        $opt['descriptionSelector'] = "'dd.tabs'";

When I remove the single quotes from here the tabs are properly displayed.

@nicksavov
Copy link
Contributor

Thanks for posting this, Daniel! Can you send a pull request? If you need to learn how, check out this tutorial:
http://docs.joomla.org/Git_for_Coders

I also created a tracker item for this issue:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30855

You can receive notifications from it by signing in, going to the item, and clicking "Monitor Item" in the left column.

While we’re transitioning to a new integrated tracker, the JoomlaCode tracker is where we do most of Joomla's bug fixing. You can find out more about the process at:
http://docs.joomla.org/Filing_bugs_and_issues

I'm going to close this item, since we have the above JoomlaCode Tracker Item. If and when you submit a pull request, please reference the JoomlaCode Tracker Item URL:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30855

Let me know if you have any questions and I'll be glad to answer. Thanks again, Daniel!

dneukirchen pushed a commit to dneukirchen/joomla-cms that referenced this issue Oct 4, 2017
bembelimen pushed a commit to bembelimen/joomla-cms that referenced this issue Aug 8, 2019
Fixing selector for toolbars in systemtests for com_media
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants