Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ReCaptcha #14734

Closed
tonypartridge opened this issue Mar 18, 2017 · 5 comments
Closed

Default ReCaptcha #14734

tonypartridge opened this issue Mar 18, 2017 · 5 comments

Comments

@tonypartridge
Copy link
Contributor

tonypartridge commented Mar 18, 2017

Steps to reproduce the issue

View: Global Config -> Site -> Default ReCaptcha. If no plugins are enabled it shows - None Selected -. This is misleading since they cannot select a ReCaptcha Plugin.

I suggest we also override the getInput method and change noticed, do not render a list and instead output a message:

No ReCaptcha plugins enabled/installed.

Or similar.

Thoughts?

#UX ?

@brianteeman
Copy link
Contributor

brianteeman commented Mar 18, 2017 via email

@brianteeman
Copy link
Contributor

brianteeman commented Mar 18, 2017 via email

@tonypartridge
Copy link
Contributor Author

tonypartridge commented Mar 18, 2017

@brianteeman No, you set the Captcha in the global config as per my notes above see:

screen shot 2017-03-18 at 16 43 40

This produces a select list which is indicating the to user they can select something. Nothing is selectable since no Captcha plugins are enabled by default. Furthermore, the ReCaptcha plugin lets you choose between two versions of ReCaptcha.

@tonypartridge tonypartridge changed the title Default ReCaptcha [4.0] Default ReCaptcha Mar 18, 2017
@joomla-cms-bot joomla-cms-bot changed the title [4.0] Default ReCaptcha Default ReCaptcha Mar 30, 2017
@joomla-cms-bot joomla-cms-bot changed the title Default ReCaptcha [4.0] Default ReCaptcha Apr 3, 2017
@brianteeman
Copy link
Contributor

@tonypartridge would you be happy with a quick fix of just changing the string from "none selected" to just "none"

@tonypartridge tonypartridge changed the title [4.0] Default ReCaptcha Default ReCaptcha Mar 24, 2018
@tonypartridge
Copy link
Contributor Author

Closing as we have a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants