Speed up regex in emailcloak plugin (#20956)

* Speed up regex in emailcloak plugin * Fix comment
joomla · Jul 21, 2018 · d6e33a4 · d6e33a4
1 parent 8655c2c
commit d6e33a4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/plugins/content/emailcloak/emailcloak.php b/plugins/content/emailcloak/emailcloak.php
@@ -484,9 +484,9 @@ protected function _cloak(&$text, &$params)
 		/*
 		 * Search for plain text email addresses, such as email@example.org but not within HTML tags:
 		 * <img src="..." title="email@example.org"> or <input type="text" placeholder="email@example.org">
-		 * The negative lookahead '(?![^<]*>)' is used to exclude this kind of occurrences
+		 * The '<[^<]*>(*SKIP)(*F)|' trick is used to exclude this kind of occurrences
 		 */
-		$pattern = '~(?![^<>]*>)' . $searchEmail . '~i';
+		$pattern = '~<[^<]*>(*SKIP)(*F)|' . $searchEmail . '~i';
 
 		while (preg_match($pattern, $text, $regs, PREG_OFFSET_CAPTURE))
 		{