Skip to content

Commit

Permalink
implement check provided by @ggppdk
Browse files Browse the repository at this point in the history
  • Loading branch information
zero-24 committed Feb 26, 2018
1 parent a6f9021 commit c804164
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 1 addition & 3 deletions administrator/components/com_admin/models/sysinfo.php
Original file line number Diff line number Diff line change
Expand Up @@ -239,16 +239,14 @@ public function &getPhpSettings()
return $this->php_settings;
}

$outputBuffering = ini_get('output_buffering');

$this->php_settings = array(
'safe_mode' => ini_get('safe_mode') == '1',
'display_errors' => ini_get('display_errors') == '1',
'short_open_tag' => ini_get('short_open_tag') == '1',
'file_uploads' => ini_get('file_uploads') == '1',
'magic_quotes_gpc' => ini_get('magic_quotes_gpc') == '1',
'register_globals' => ini_get('register_globals') == '1',
'output_buffering' => ($outputBuffering === 'On') ? true : is_numeric($outputBuffering),
'output_buffering' => (int) ini_get('output_buffering') !== 0,
'open_basedir' => ini_get('open_basedir'),
'session.save_path' => ini_get('session.save_path'),
'session.auto_start' => ini_get('session.auto_start'),
Expand Down
3 changes: 1 addition & 2 deletions installation/model/setup.php
Original file line number Diff line number Diff line change
Expand Up @@ -372,10 +372,9 @@ public function getPhpSettings()
$settings[] = $setting;

// Check for output buffering.
$outputBuffering = ini_get('output_buffering');
$setting = new stdClass;
$setting->label = JText::_('INSTL_OUTPUT_BUFFERING');
$setting->state = ($outputBuffering === 'On') ? true : is_numeric($outputBuffering);
$setting->state = (int) ini_get('output_buffering') !== 0;
$setting->recommended = false;
$settings[] = $setting;

Expand Down

0 comments on commit c804164

Please sign in to comment.