[4] Fix trash menu items displaying logic (#33406)

Fix trashing items ACL checks
joomla · Apr 30, 2021 · aedf7e3 · aedf7e3
1 parent 1e35de4
commit aedf7e3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/administrator/components/com_languages/src/View/Languages/HtmlView.php b/administrator/components/com_languages/src/View/Languages/HtmlView.php
@@ -124,7 +124,7 @@ protected function addToolbar(): void
 			$childBar->publish('languages.publish')->listCheck(true);
 			$childBar->unpublish('languages.unpublish')->listCheck(true);
 
-			if (!$this->state->get('filter.published') == -2)
+			if ($this->state->get('filter.published') != -2)
 			{
 				$childBar->trash('languages.trash')->listCheck(true);
 			}

diff --git a/administrator/components/com_newsfeeds/src/View/Newsfeeds/HtmlView.php b/administrator/components/com_newsfeeds/src/View/Newsfeeds/HtmlView.php
@@ -163,7 +163,7 @@ protected function addToolbar()
 				$childBar->checkin('newsfeeds.checkin')->listCheck(true);
 			}
 
-			if (!$this->state->get('filter.published') == -2)
+			if ($this->state->get('filter.published') != -2)
 			{
 				$childBar->trash('newsfeeds.trash')->listCheck(true);
 			}

diff --git a/administrator/components/com_tags/src/View/Tags/HtmlView.php b/administrator/components/com_tags/src/View/Tags/HtmlView.php
@@ -165,7 +165,7 @@ protected function addToolbar()
 				$childBar->checkin('tags.checkin')->listCheck(true);
 			}
 
-			if ($canDo->get('core.edit.state') && !$this->state->get('filter.published') == -2)
+			if ($canDo->get('core.edit.state') && $this->state->get('filter.published') != -2)
 			{
 				$childBar->trash('tags.trash')->listCheck(true);
 			}

diff --git a/administrator/components/com_users/src/View/Notes/HtmlView.php b/administrator/components/com_users/src/View/Notes/HtmlView.php
@@ -164,7 +164,7 @@ protected function addToolbar()
 				$childBar->checkin('notes.checkin')->listCheck(true);
 			}
 
-			if (!$this->state->get('filter.published') == -2 && $canDo->get('core.edit.state'))
+			if ($this->state->get('filter.published') != -2 && $canDo->get('core.edit.state'))
 			{
 				$childBar->trash('notes.trash');
 			}