Skip to content

Commit

Permalink
[4.0] icon for non featured (#33417)
Browse files Browse the repository at this point in the history
  • Loading branch information
brianteeman authored Apr 30, 2021
1 parent 3239d0d commit 9c0b9f3
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public function featured($value, $i, $canChange = true)
1 => array('featured', 'contacts.unfeatured', 'JFEATURED', 'JGLOBAL_ITEM_UNFEATURE'),
);
$state = ArrayHelper::getValue($states, (int) $value, $states[1]);
$icon = $state[0] === 'featured' ? 'star featured' : 'star';
$icon = $state[0] === 'featured' ? 'star featured' : 'circle';

if ($canChange)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ protected function addToolbar()
->text('JFEATURE')
->task('contacts.featured')
->listCheck(true);
$childBar->standardButton('unfeatured')
$childBar->standardButton('circle')
->text('JUNFEATURE')
->task('contacts.unfeatured')
->listCheck(true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ protected function addToolbar()
->task('articles.featured')
->listCheck(true);

$childBar->standardButton('unfeatured')
$childBar->standardButton('circle')
->text('JUNFEATURE')
->task('articles.unfeatured')
->listCheck(true);
Expand Down
2 changes: 1 addition & 1 deletion libraries/src/Button/FeaturedButton.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class FeaturedButton extends ActionButton
*/
protected function preprocess()
{
$this->addState(0, 'featured', 'icon-color-unfeatured icon-star',
$this->addState(0, 'featured', 'icon-circle',
Text::_('JGLOBAL_TOGGLE_FEATURED'), ['tip_title' => Text::_('JUNFEATURED')]
);
$this->addState(1, 'unfeatured', 'icon-color-featured icon-star',
Expand Down
2 changes: 1 addition & 1 deletion libraries/src/HTML/Helpers/JGrid.php
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ public static function published($value, $i, $prefix = '', $enabled = true, $che
* @see JHtmlJGrid::state()
* @since 1.6
*/
public static function isdefault($value, $i, $prefix = '', $enabled = true, $checkbox = 'cb', $formId = null, $active_class = 'icon-color-featured icon-star', $inactive_class = 'icon-color-unfeatured icon-star')
public static function isdefault($value, $i, $prefix = '', $enabled = true, $checkbox = 'cb', $formId = null, $active_class = 'icon-color-featured icon-star', $inactive_class = 'icon-circle')
{
if (is_array($prefix))
{
Expand Down

0 comments on commit 9c0b9f3

Please sign in to comment.