Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made text to speech voice adapt to the website language #5

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Shubhamverma2796
Copy link
Collaborator

@Shubhamverma2796 Shubhamverma2796 commented Sep 1, 2022

Summary of changes

This pr combined with joomla-projects/gsoc22_accessibility-plugin-script#8 fixes : https://forum.joomla.org/viewtopic.php?f=808&t=991513&p=3651110

Testing Instructions

  1. Change the site language to any other language other than en-us.
  2. Enable text-to-speech in a11y plugin.
  3. Check if the voice of the text-to-speech speaker changes to site language.

Note: It is possible that the selected language is not supported by the speechSynthesis API, in that case 'en-US' will be be the default language.

Actual result BEFORE applying this Pull Request

The voice of the text to speech speaker remains same(en-US) irrespective of the site language.

Expected result AFTER applying this Pull Request

The voice of the text-to-speech speaker changes to site language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants