This repository has been archived by the owner on Nov 7, 2021. It is now read-only.
Set Machine's public_dns in AWS and private_ip in Azure #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhoo
reviewed
Jun 26, 2020
jonhoo
approved these changes
Jun 26, 2020
jonhoo
reviewed
Jun 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets
Machine.public_dnsin AWS andMachine.private_ipin Azure (information we had, that was just not being recorded).While doing this change, the logic of "setting public_dns equal to public_ip if there's no public_dns" was moved up to
connect_ssh. Now this rule lives in this single place.(For some sanity, I've also reordered some things to make sure that the following order is maintained:
public_dns,public_ip, andprivate_ip)