Make the sealed CollapsePrivate trait public again
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It needs to be in the public API due to the blanket implementation of `Collapse` for `T: CollapsePrivate`. The `inferno::collapse::common` module is crate-private, ensuring that `CollapsePrivate` and `Occurrences` cannot be named by downstream library users. Closes jonhoo#264.
jonhoo
approved these changes
Sep 29, 2022
Codecov ReportBase: 90.21% // Head: 90.21% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
=======================================
Coverage 90.21% 90.21%
=======================================
Files 19 19
Lines 4179 4179
=======================================
Hits 3770 3770
Misses 409 409
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Released as 0.11.9 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs to be in the public API due to the blanket implementation of
CollapseforT: CollapsePrivate. Theinferno::collapse::commonmodule is crate-private, ensuring thatCollapsePrivateandOccurrencescannot be named by downstream library users.Closes #264.