Undo changes from #242 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.21% // Head: 90.21% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
=======================================
Coverage 90.21% 90.21%
=======================================
Files 19 19
Lines 4179 4179
=======================================
Hits 3770 3770
Misses 409 409 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jonhoo
approved these changes
Sep 28, 2022
|
Thanks! Released in 0.11.8 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261
I'm not reproducing #241 anymore, may just be luck though (it was intermittent). If this makes it start happening again I'll try again with some other approach, but I feel like having wrong width is a lot worse than occasional extra padding on the bottom.