Use text-anchor instead of hardcoded offsets #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhoo
requested changes
Jul 18, 2022
jonhoo
reviewed
Jul 18, 2022
jonhoo
reviewed
Jul 26, 2022
This was proposed by `@nagisa` in jonhoo#247, I just applied the suggestions, tested that the result was as expected. I tried the suggestion of `dominant-baseline="hanging"`, but it will need further work to make it usefull as applying instead will just increase the size of the css without reducing enough in the SVG. Co-authored-by: Simonas Kazlauskas <git@kazlauskas.me> Fixes jonhoo#247
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 18 18
Lines 2541 2541
=======================================
Hits 2220 2220
Misses 321 321
Continue to review full report at Codecov.
|
jonhoo
approved these changes
Jul 26, 2022
|
Thanks! |
|
Released in 0.11.7 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was proposed by
@nagisain #247, I just applied the suggestions and tested that the result was as expected.I tried the suggestion of
dominant-baseline="hanging", but it will need further work to make it useful as applying instead will just increase the size of the CSS without reducing enough in the SVG.Fixes #247