Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't quote generic font families in CSS #252

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

jasonrhansen
Copy link
Collaborator

Fixes #244

When passing a font type to use for the generated flamegraph,
if it is one of the following we shouldn't put quotes around it:

  • cursive
  • fantasy
  • monospace
  • serif
  • sans-serif

When passing a font type to use for the generated flamegraph,
if it is one of the following we shouldn't put quotes around it:

* cursive
* fantasy
* monospace
* serif
* sans-serif
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #252 (7f2d74a) into master (acc8981) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   87.32%   87.30%   -0.03%     
==========================================
  Files          18       18              
  Lines        2525     2528       +3     
==========================================
+ Hits         2205     2207       +2     
- Misses        320      321       +1     
Impacted Files Coverage Δ
src/flamegraph/svg.rs 75.90% <75.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc8981...7f2d74a. Read the comment docs.

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, actually, can you add to CHANGELOG.md while you're at it?

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonhoo jonhoo merged commit d6a6e21 into jonhoo:master Jun 23, 2022
@jonhoo
Copy link
Owner

jonhoo commented Jun 23, 2022

Released in 0.11.6 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to set font in flamegraphs to default fonts
2 participants