Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from lazy_static to once_cell::Lazy #249

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

Sciencentistguy
Copy link
Contributor

lazy_static is only passively maintained. Also, once_cell is faster (1-5% across cargo bench).

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #249 (cd99b59) into master (172c9f4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   87.21%   87.22%   +0.01%     
==========================================
  Files          18       18              
  Lines        2527     2529       +2     
==========================================
+ Hits         2204     2206       +2     
  Misses        323      323              
Impacted Files Coverage Δ
src/collapse/common.rs 59.25% <100.00%> (ø)
src/collapse/dtrace.rs 90.62% <100.00%> (+0.04%) ⬆️
src/collapse/perf.rs 97.98% <100.00%> (+<0.01%) ⬆️
src/flamegraph/mod.rs 87.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 172c9f4...cd99b59. Read the comment docs.

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thank you!

@jonhoo jonhoo merged commit bedac77 into jonhoo:master Jun 19, 2022
@jonhoo
Copy link
Owner

jonhoo commented Jun 19, 2022

Published in 0.11.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants