Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identified external dependencies with js color palette #234

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

daniellockyer
Copy link
Contributor

@daniellockyer daniellockyer commented Mar 16, 2022

  • identifying external dependencies is useful because it enables you to
    differentiate between code in your project, and code that you import
    in
  • this commit adds an if-statement to check for the node_modules/
    string, and colors it purple if found

Hey @jonhoo - ❤️ Inferno 🙂

I've tested this locally with a tool I'm writing for NodeJS and it produces the following:

CleanShot 2022-03-16 at 10 15 20@2x

@daniellockyer
Copy link
Contributor Author

daniellockyer commented Mar 16, 2022

As a reference for colors, 0x colors external dependencies in purple, and I think it looks good in Inferno too 🙂

CleanShot 2022-03-16 at 10 26 17@2x

- identifying external dependencies is useful because it enables you to
  differentiate between code in your project, and code that you import
  in
- this commit adds an if-statement to check for the `node_modules/`
  string, and colorizes it purple if found
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I love it. Thanks!

@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #234 (0ca49de) into master (06b22f3) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

❗ Current head 0ca49de differs from pull request most recent head f7d14c3. Consider uploading reports for the commit f7d14c3 to get more accurate results

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   86.85%   86.82%   -0.04%     
==========================================
  Files          17       17              
  Lines        2396     2398       +2     
==========================================
+ Hits         2081     2082       +1     
- Misses        315      316       +1     
Impacted Files Coverage Δ
src/flamegraph/color/palettes.rs 99.09% <66.66%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b22f3...f7d14c3. Read the comment docs.

@jonhoo jonhoo merged commit 7dd673c into jonhoo:master Mar 19, 2022
@jonhoo
Copy link
Owner

jonhoo commented Mar 19, 2022

Hmm, not entirely sure why CI isn't running. I think it's because I need to "approve and run", but that button doesn't appear. Seems to be some kind of GitHub bug. I'm running the test suite locally, and then I'll update the changelog and publish!

@jonhoo
Copy link
Owner

jonhoo commented Mar 19, 2022

Released in 0.11.1 🎉

daniellockyer added a commit to daniellockyer/node-memory-flamegraphs that referenced this pull request Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants