Make behavior of skip_after more consistent. #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
==========================================
+ Coverage 87.00% 87.03% +0.02%
==========================================
Files 17 17
Lines 2378 2383 +5
==========================================
+ Hits 2069 2074 +5
Misses 309 309
Continue to review full report at Codecov.
|
Specifically, omits process name as a root frame if `skip_after` condition was trigerred. Also, I added "skip-after" flag to collapse-perf.rs in order to actually be able to use and test this flag on real stack traces.
|
@jonhoo addressed your comments. Please advise if the comment above is not clear. |
jonhoo
reviewed
Dec 19, 2021
|
Released in 0.10.9 🎉 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, omits process name as a root frame if
skip_aftercondition was trigerred.Also, I added "skip-after" flag to collapse-perf.rs in order to actually be able to use
and test this flag on real stack traces.