Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping stack frames after a specified frame name #222

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

romange
Copy link
Contributor

@romange romange commented Oct 18, 2021

Fixes #221

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #222 (4c44cfd) into master (1af0e9c) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 4c44cfd differs from pull request most recent head cb00a28. Consider uploading reports for the commit cb00a28 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   86.91%   87.01%   +0.10%     
==========================================
  Files          17       17              
  Lines        2361     2380      +19     
==========================================
+ Hits         2052     2071      +19     
  Misses        309      309              
Impacted Files Coverage Δ
src/collapse/perf.rs 97.83% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af0e9c...cb00a28. Read the comment docs.

@romange romange force-pushed the master branch 3 times, most recently from 4e06955 to 877f9c3 Compare October 20, 2021 14:41
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for stepping up to submit this! Left a few notes inline :)

src/collapse/perf.rs Outdated Show resolved Hide resolved
src/collapse/perf.rs Outdated Show resolved Hide resolved
src/collapse/perf.rs Show resolved Hide resolved
src/collapse/perf.rs Outdated Show resolved Hide resolved
@romange romange force-pushed the master branch 3 times, most recently from 5945bbe to da09009 Compare October 24, 2021 18:30
@romange
Copy link
Contributor Author

romange commented Oct 24, 2021

it seems that clippy warnings are unrelated to this PR.

src/collapse/perf.rs Outdated Show resolved Hide resolved
src/collapse/perf.rs Show resolved Hide resolved
src/collapse/perf.rs Show resolved Hide resolved
src/collapse/perf.rs Outdated Show resolved Hide resolved
@jonhoo
Copy link
Owner

jonhoo commented Oct 24, 2021

btw, the clippy error should be fixed in master now.

@romange
Copy link
Contributor Author

romange commented Nov 2, 2021

Hi @jonhoo , could you please take another look?

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks!

@jonhoo jonhoo merged commit 2252b1b into jonhoo:master Nov 3, 2021
@jonhoo
Copy link
Owner

jonhoo commented Nov 3, 2021

Released in 0.10.8 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request - implement skip_after
2 participants