Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collapser for VTune #148

Merged
merged 7 commits into from
Sep 13, 2019
Merged

Add collapser for VTune #148

merged 7 commits into from
Sep 13, 2019

Conversation

jasonrhansen
Copy link
Collaborator

Implements #142

jonhoo
jonhoo reviewed Sep 12, 2019
View reviewed changes
src/bin/collapse-vtune.rs Outdated Show resolved Hide resolved
jonhoo
jonhoo reviewed Sep 12, 2019
View reviewed changes
src/collapse/vtune.rs Outdated Show resolved Hide resolved
jonhoo
jonhoo reviewed Sep 12, 2019
View reviewed changes
src/collapse/vtune.rs Outdated Show resolved Hide resolved
jonhoo
jonhoo reviewed Sep 13, 2019
View reviewed changes
src/collapse/vtune.rs Outdated Show resolved Hide resolved
jonhoo
jonhoo reviewed Sep 13, 2019
View reviewed changes
tests/common/collapse.rs Outdated Show resolved Hide resolved
jonhoo
jonhoo requested changes Sep 13, 2019
View reviewed changes
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you please also update the changelog?

@jasonrhansen jasonrhansen merged commit e833dbb into jonhoo:master Sep 13, 2019
@jasonrhansen jasonrhansen deleted the collapse-vtune branch September 13, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo jonhoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonrhansen @jonhoo