Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demangle option to collapsers #132

Merged
merged 6 commits into from
Jul 2, 2019
Merged

Conversation

jasonrhansen
Copy link
Collaborator

Fixes #87

This is only useful if you pass --no-demangle to perf script, or -xmangled to dtrace.

Since DTrace doesn't do a great job demangling Rust names, you can get better results by leaving names mangled in profiles, then passing --demangle to inferno-collapse-dtrace. It would probably make sense for ferrous-systems/flamegraph to use DTrace this way.

src/collapse/dtrace.rs Outdated Show resolved Hide resolved
src/collapse/dtrace.rs Outdated Show resolved Hide resolved
jonhoo
jonhoo previously approved these changes Jul 2, 2019
@jonhoo
Copy link
Owner

jonhoo commented Jul 2, 2019

Looks like rustfmt is complaining: https://travis-ci.com/jonhoo/inferno/jobs/212451904

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #132 into master will decrease coverage by 0.39%.
The diff coverage is 70.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #132     +/-   ##
=========================================
- Coverage   90.12%   89.72%   -0.4%     
=========================================
  Files           8        8             
  Lines         962      983     +21     
=========================================
+ Hits          867      882     +15     
- Misses         95      101      +6
Impacted Files Coverage Δ
src/collapse/dtrace.rs 84% <70%> (-1.72%) ⬇️
src/collapse/perf.rs 92.07% <75%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994b61f...e8397b2. Read the comment docs.

src/collapse/dtrace.rs Outdated Show resolved Hide resolved
src/collapse/dtrace.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back demangling support
2 participants