Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding strokes to the rectangles representing a stack frame #248

Closed
nagisa opened this issue Jun 16, 2022 · 1 comment · Fixed by #255
Closed

Consider adding strokes to the rectangles representing a stack frame #248

nagisa opened this issue Jun 16, 2022 · 1 comment · Fixed by #255

Comments

@nagisa
Copy link

nagisa commented Jun 16, 2022

This is leaning towards a stylistic preference somewhat, but adding a stroke to all of the rectangles in a flamegraph should serve as a great way to separate the boxes from each other, especially when they are touching together. Today colour sets include multiple colours and one of the reasons for this I think to differentiate these frames that are touching together.

A stroke would also enable colour sets that are flatter, where colours are used to mark different types of frames, like proposed in #203.

Here's an example of what it might end up looking like. Note especially the rustix::io::mmap::mprotect and frames around it:

A screenshot of a flamegraph with some boxes touching

@jonhoo
Copy link
Owner

jonhoo commented Jun 19, 2022

That's an interesting idea. I'm not a huge fan of it myself, but I could see it making certain graphs (much) easier to read. Maybe an option for this would be a good addition?

Urgau added a commit to Urgau/inferno that referenced this issue Jul 17, 2022
This was proposed by `@nagisa` in
jonhoo#248.

The new option will be `--stroke-color` and default to `none`
and accept any color. It use a non-configurable stroke width of 1.

Fixes jonhoo#248
Urgau added a commit to Urgau/inferno that referenced this issue Jul 18, 2022
This was proposed by `@nagisa` in
jonhoo#248.

The new option will be `--stroke-color` and default to `none`
and accept any color. It use a non-configurable stroke width of 1.

Fixes jonhoo#248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants