Skip to content

Release 0.11.20

Release 0.11.20 #270

Triggered via pull request July 14, 2024 14:19
Status Failure
Total duration 2m 46s
Artifacts

test.yml

on: pull_request
ubuntu / stable / minimal-versions
56s
ubuntu / stable / minimal-versions
ubuntu / stable / coverage
53s
ubuntu / stable / coverage
Matrix: os-check
Matrix: required
Fit to window
Zoom out
Zoom in

Annotations

1 error and 21 warnings
ubuntu / stable / coverage
Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255
assigning the result of `ToOwned::to_owned()` may be inefficient: src/bin/flamegraph.rs#L270
warning: assigning the result of `ToOwned::to_owned()` may be inefficient --> src/bin/flamegraph.rs:270:13 | 270 | options.title = defaults::CHART_TITLE.to_owned(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `defaults::CHART_TITLE.clone_into(&mut options.title)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
assigning the result of `Clone::clone()` may be inefficient: src/bin/flamegraph.rs#L242
warning: assigning the result of `Clone::clone()` may be inefficient --> src/bin/flamegraph.rs:242:9 | 242 | options.title = self.title.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `options.title.clone_from(&self.title)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default
redundant guard: src/flamegraph/mod.rs#L620
warning: redundant guard --> src/flamegraph/mod.rs:620:32 | 620 | Some(delta) if delta == 0 => write!( | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards = note: `#[warn(clippy::redundant_guards)]` on by default help: try | 620 - Some(delta) if delta == 0 => write!( 620 + Some(0) => write!( |
usage of a legacy numeric constant: src/flamegraph/color/mod.rs#L395
warning: usage of a legacy numeric constant --> src/flamegraph/color/mod.rs:395:36 | 395 | let hash3 = (hash as f64 / std::u64::MAX as f64) as f32; | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 395 | let hash3 = (hash as f64 / u64::MAX as f64) as f32; | ~~~~~~~~
usage of a legacy numeric constant: src/flamegraph/color/mod.rs#L392
warning: usage of a legacy numeric constant --> src/flamegraph/color/mod.rs:392:36 | 392 | let hash2 = (hash as f64 / std::u64::MAX as f64) as f32; | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 392 | let hash2 = (hash as f64 / u64::MAX as f64) as f32; | ~~~~~~~~
usage of a legacy numeric constant: src/flamegraph/color/mod.rs#L387
warning: usage of a legacy numeric constant --> src/flamegraph/color/mod.rs:387:36 | 387 | let hash1 = (hash as f64 / std::u64::MAX as f64) as f32; | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 387 | let hash1 = (hash as f64 / u64::MAX as f64) as f32; | ~~~~~~~~
file opened with `create`, but `truncate` behavior not defined: src/flamegraph/color/palette_map.rs#L104
warning: file opened with `create`, but `truncate` behavior not defined --> src/flamegraph/color/palette_map.rs:104:55 | 104 | let mut file = OpenOptions::new().write(true).create(true).open(path)?; | ^^^^^^^^^^^^- help: add: `.truncate(true)` | = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` = help: alternatively, use `.append(true)` to append to the file instead of overwriting it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options = note: `#[warn(clippy::suspicious_open_options)]` on by default
this `if` statement can be collapsed: src/collapse/perf.rs#L549
warning: this `if` statement can be collapsed --> src/collapse/perf.rs:549:24 | 549 | } else if self.opt.annotate_jit | ________________________^ 550 | | && ((module.starts_with("/tmp/perf-") && module.ends_with(".map")) 551 | | || (module.contains("/jitted-") && module.ends_with(".so"))) 552 | | { ... | 555 | | } 556 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 549 ~ } else if self.opt.annotate_jit && ((module.starts_with("/tmp/perf-") && module.ends_with(".map")) 550 + || (module.contains("/jitted-") && module.ends_with(".so"))) && !func.contains("_[j]") { 551 + func.push_str("_[j]"); // jitted 552 + } |
the borrowed expression implements the required traits: src/flamegraph/mod.rs#L919
warning: the borrowed expression implements the required traits --> src/flamegraph/mod.rs:919:21 | 919 | svg.write_event(&cache_rect) | ^^^^^^^^^^^ help: change this to: `cache_rect` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/flamegraph/mod.rs#L769
warning: the borrowed expression implements the required traits --> src/flamegraph/mod.rs:769:25 | 769 | svg.write_event(&cache_g)?; | ^^^^^^^^ help: change this to: `cache_g` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/flamegraph/mod.rs#L762
warning: the borrowed expression implements the required traits --> src/flamegraph/mod.rs:762:29 | 762 | svg.write_event(&cache_g)?; | ^^^^^^^^ help: change this to: `cache_g` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/flamegraph/mod.rs#L758
warning: the borrowed expression implements the required traits --> src/flamegraph/mod.rs:758:29 | 758 | svg.write_event(&cache_a)?; | ^^^^^^^^ help: change this to: `cache_a` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
redundant guard: src/flamegraph/mod.rs#L620
warning: redundant guard --> src/flamegraph/mod.rs:620:32 | 620 | Some(delta) if delta == 0 => write!( | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards = note: `#[warn(clippy::redundant_guards)]` on by default help: try | 620 - Some(delta) if delta == 0 => write!( 620 + Some(0) => write!( |
usage of a legacy numeric constant: src/flamegraph/color/mod.rs#L395
warning: usage of a legacy numeric constant --> src/flamegraph/color/mod.rs:395:36 | 395 | let hash3 = (hash as f64 / std::u64::MAX as f64) as f32; | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 395 | let hash3 = (hash as f64 / u64::MAX as f64) as f32; | ~~~~~~~~
usage of a legacy numeric constant: src/flamegraph/color/mod.rs#L392
warning: usage of a legacy numeric constant --> src/flamegraph/color/mod.rs:392:36 | 392 | let hash2 = (hash as f64 / std::u64::MAX as f64) as f32; | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 392 | let hash2 = (hash as f64 / u64::MAX as f64) as f32; | ~~~~~~~~
usage of a legacy numeric constant: src/flamegraph/color/mod.rs#L387
warning: usage of a legacy numeric constant --> src/flamegraph/color/mod.rs:387:36 | 387 | let hash1 = (hash as f64 / std::u64::MAX as f64) as f32; | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 387 | let hash1 = (hash as f64 / u64::MAX as f64) as f32; | ~~~~~~~~
file opened with `create`, but `truncate` behavior not defined: src/flamegraph/color/palette_map.rs#L104
warning: file opened with `create`, but `truncate` behavior not defined --> src/flamegraph/color/palette_map.rs:104:55 | 104 | let mut file = OpenOptions::new().write(true).create(true).open(path)?; | ^^^^^^^^^^^^- help: add: `.truncate(true)` | = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` = help: alternatively, use `.append(true)` to append to the file instead of overwriting it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options = note: `#[warn(clippy::suspicious_open_options)]` on by default
this `if` statement can be collapsed: src/collapse/perf.rs#L549
warning: this `if` statement can be collapsed --> src/collapse/perf.rs:549:24 | 549 | } else if self.opt.annotate_jit | ________________________^ 550 | | && ((module.starts_with("/tmp/perf-") && module.ends_with(".map")) 551 | | || (module.contains("/jitted-") && module.ends_with(".so"))) 552 | | { ... | 555 | | } 556 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 549 ~ } else if self.opt.annotate_jit && ((module.starts_with("/tmp/perf-") && module.ends_with(".map")) 550 + || (module.contains("/jitted-") && module.ends_with(".so"))) && !func.contains("_[j]") { 551 + func.push_str("_[j]"); // jitted 552 + } |
unexpected `cfg` condition value: `nightly`: src/lib.rs#L151
warning: unexpected `cfg` condition value: `nightly` --> src/lib.rs:151:17 | 151 | #[cfg(all(test, feature = "nightly"))] | ^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `clap`, `cli`, `crossbeam-channel`, `crossbeam-utils`, `dashmap`, `default`, `env_logger`, `indexmap`, `multithreaded`, `nameattr`, `regex`, and `rle-decode-fast` = help: consider adding `nightly` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `nightly`: src/lib.rs#L148
warning: unexpected `cfg` condition value: `nightly` --> src/lib.rs:148:23 | 148 | #![cfg_attr(all(test, feature = "nightly"), feature(test))] | ^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `clap`, `cli`, `crossbeam-channel`, `crossbeam-utils`, `dashmap`, `default`, `env_logger`, `indexmap`, `multithreaded`, `nameattr`, `regex`, and `rle-decode-fast` = help: consider adding `nightly` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default
ubuntu / stable / coverage
The following actions uses Node.js version which is deprecated and will be forced to run on node20: codecov/codecov-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/