Add IfIsHumanReadable #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #690 +/- ##
==========================================
+ Coverage 65.29% 65.41% +0.11%
==========================================
Files 38 38
Lines 2314 2322 +8
==========================================
+ Hits 1511 1519 +8
Misses 803 803 ☔ View full report in Codecov by Sentry. |
irriden
force-pushed
the
human-readable
branch
from
8ebca85
to
47d974f
Compare
|
This already looks really good :) It has all the parts, documentation, test, and a mention in the user guide. I will merge this as is. |
|
@jonasbb thanks for the review, any chance you can merge and release this soon ? I have a downstream PR dependent on this work here thanks :) Also let me know if further changes are needed. |
|
Sure, I published 3.6.0 containing this change. Thanks again for preparing it. |
No problem my pleasure thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #687
Used to specify different transformations for text-based and binary formats.