Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt: make a better effort to configure terminal for Readline #1342

Closed
wants to merge 1 commit into from

Conversation

intelfx
Copy link
Contributor

@intelfx intelfx commented Jun 15, 2024

This fixes ^C behavior within the Readline prompt. This does not implement any sane ESC handling, nor does it seem to handle ^C after an outstanding ESC.

Still better than nothing.

This fixes ^C behavior within the Readline prompt.
This does _not_ implement any sane ESC handling, nor does it seem to
handle ^C after an outstanding ESC. Still better than nothing.
koutcher pushed a commit that referenced this pull request Jul 20, 2024
[tk: fixed regression with the `Enter` key]
@koutcher koutcher closed this Jul 20, 2024
@intelfx
Copy link
Contributor Author

intelfx commented Jul 20, 2024

Right, I spotted the Enter regression after a few days but did not get around to investigating it again. Thanks :)

@intelfx intelfx deleted the work/readline-fixes branch July 20, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants