Upgraded to node-sass 2.0.1 #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for that, cause 1.2.3 failing with node 0.12 sass/node-sass#550 |
|
just bitted us too. |
|
+1 for this. |
|
👍 For the moment downgrading to |
|
Is 2.0.1 backward compatible? If so this should definitely go in. homebrew just stated shipping node 0.12 as default. |
mixonic
added a commit
to mixonic/diesel.aptible.com
that referenced
this pull request
Feb 20, 2015
Needed until joliss/broccoli-sass#49 or another fix lands in broccoli-sass.
mixonic
added a commit
to mixonic/diesel.aptible.com
that referenced
this pull request
Feb 20, 2015
Needed until joliss/broccoli-sass#49 or another fix lands in broccoli-sass.
mixonic
added a commit
to mixonic/diesel.aptible.com
that referenced
this pull request
Feb 20, 2015
Needed until joliss/broccoli-sass#49 or another fix lands in broccoli-sass.
|
👍 We're in the same boat. |
| var includePathSearcher = require('include-path-searcher'); | ||
| var CachingWriter = require('broccoli-caching-writer'); | ||
| var sass = require('node-sass'); | ||
| var _ = require('lodash'); |
There was a problem hiding this comment.
although this is pre-existing, we should require the exact part of lodash that we need. Otherwise this can be a spin up hit.
|
@hipertracker Thanks for this PR! The diff was a little bit too long to review effectively ;-) - it's basically a rewrite - but I updated the dependency myself in 6e600fe and released it in v0.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade node-sass to 2.0.1. (Older node-sass version is not working on OS X)