Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add visible prop to Pane #137

Merged
merged 2 commits into from
Feb 8, 2022
Merged

feat: add visible prop to Pane #137

merged 2 commits into from
Feb 8, 2022

Conversation

johnwalley
Copy link
Owner

@johnwalley johnwalley commented Jan 23, 2022

Set whether a pane is visible.

I think this interacts with snapping behaviour. In that if snapping a pane sets the visibility to false then it would preclude using some external state to control whether the pane is visible.

If this is the case then a solution is to add an onChange callback which will notify the caller of any changes to the Pane's props (probably just visible to start with).

@johnwalley johnwalley added the enhancement New feature or request label Jan 23, 2022
@netlify
Copy link

netlify bot commented Jan 23, 2022

✔️ Deploy Preview for allotment-website ready!

🔨 Explore the source changes: d462637

🔍 Inspect the deploy log: https://app.netlify.com/sites/allotment-website/deploys/62023ddf250146000899552a

😎 Browse the preview: https://deploy-preview-137--allotment-website.netlify.app

@netlify
Copy link

netlify bot commented Jan 23, 2022

✔️ Deploy Preview for allotment-storybook ready!

🔨 Explore the source changes: d462637

🔍 Inspect the deploy log: https://app.netlify.com/sites/allotment-storybook/deploys/62023ddfd9be3f0007e12b49

😎 Browse the preview: https://deploy-preview-137--allotment-storybook.netlify.app

@Stormix
Copy link

Stormix commented Feb 7, 2022

Hello there! Thanks a lot for the handy package, and updates on this?

@johnwalley
Copy link
Owner Author

Hello there! Thanks a lot for the handy package, and updates on this?

I've not had time to think through all the implications of this PR yet. But what I could do is release the feature as-is and see how people get on with it. I'll aim to get it out in the next few days. If I don't please give me a nudge!

@johnwalley johnwalley merged commit 3b0542c into main Feb 8, 2022
@johnwalley johnwalley deleted the pane-visibility branch February 8, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants