Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: optionally skip symlinks generation #117 #118

Merged
merged 1 commit into from
Jul 10, 2022

Conversation

kerim371
Copy link
Contributor

@kerim371 kerim371 commented Jul 10, 2022

Added --skip-symlinks flag aimed at skipping symlinks generation #117 .

closes #117

Added `--skip-symlinks` flag aimed at skipping symlinks generation.
@kerim371 kerim371 mentioned this pull request Jul 10, 2022
Copy link
Owner

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #118 (8dc4f17) into master (8c75122) will decrease coverage by 0.02%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   59.89%   59.86%   -0.03%     
==========================================
  Files          16       16              
  Lines        1379     1383       +4     
  Branches      291      295       +4     
==========================================
+ Hits          826      828       +2     
- Misses        454      456       +2     
  Partials       99       99              
Impacted Files Coverage Δ
jill/install.py 40.23% <20.00%> (-0.64%) ⬇️
jill/utils/source_utils.py 93.84% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c75122...8dc4f17. Read the comment docs.

@johnnychen94 johnnychen94 merged commit 2531d89 into johnnychen94:master Jul 10, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip symlink generation
2 participants