Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Allow Custom Dir #212

Merged
merged 15 commits into from
Aug 26, 2022
Merged

Allow Custom Dir #212

merged 15 commits into from
Aug 26, 2022

Conversation

joe-bell
Copy link
Owner

Description

Fixes #165, alternative solution to #198

Additional context

N/A


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@vercel
Copy link

vercel bot commented Aug 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 2:08PM (UTC)
example-with-11ty ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 2:08PM (UTC)
example-with-next ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 2:08PM (UTC)
example-with-remix ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 2:08PM (UTC)

@joe-bell
Copy link
Owner Author

joe-bell commented Aug 26, 2022

@JaeSeoKim rather than going back and forth to resolve trivial formatting changes, I went ahead and made the change. I really appreciate your efforts in contributing, so if it isn't too weird, can I mark you as a co-contributor on these commits?

(with your permission of course)

@JaeSeoKim
Copy link
Contributor

@joe-bell Of course it's good! Thank you for maintaining and developing a good open source! 😄

@joe-bell
Copy link
Owner Author

@JaeSeoKim consider it done, thank you!

Please do you mind giving plaiceholder@2.5.0-beta.0 a test and letting me know if it works for your use case? It's working for me, but I'd love to know how you get on

@JaeSeoKim
Copy link
Contributor

@joe-bell It works well as I want!
Import of blur-base64 data from plaiceholder@2.5.0-beta.0 of remark plugin was successful.

@joe-bell
Copy link
Owner Author

@JaeSeoKim woohoo let’s do it!

@joe-bell joe-bell merged commit 0e09dbf into main Aug 26, 2022
@joe-bell joe-bell deleted the feat/custom-dir branch August 26, 2022 14:43
Repository owner locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base folder for options (for nx with nextjs)
2 participants